Closed
Bug 1471585
Opened 8 years ago
Closed 8 years ago
Stop assuming that BookmarkingUI.anchor can be null
Categories
(Firefox :: Bookmarks & History, enhancement)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
BrowserPageActions.panelAnchorNodeForAction should always return a suitable node.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8988152 -
Flags: review?(mak77) → review?(standard8)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8988152 [details]
Bug 1471585 - Stop assuming that BookmarkingUI.anchor can be null.
https://reviewboard.mozilla.org/r/253410/#review260390
Thanks, nice simplification. Looks fine, especially as BrowserPageActions.panelAnchorNodeForAction never returns null, but throws instead, so we'd have likely already noticed if it was an issue.
Attachment #8988152 -
Flags: review?(standard8) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf15d93f5924
Stop assuming that BookmarkingUI.anchor can be null. r=standard8
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•