1471599 - Dispatch settings update to passive content modules

Status: VERIFIED FIXED

(GeckoView :: General, defect, P1)

Description

[Eugen Sawin [:esawin]]

Currently only enabled content modules are notified of setting updates.
In line with bug 1464263, we need to always dispatch setting updates to support passive modules.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1471599-1.0-Dispatch-setting-updates-to-disabled.patch

Comment 2

[Eugen Sawin [:esawin]]

Attachment: 0002-Bug-1471599-2.0-Use-per-session-tracking-protection-.patch

Comment 3

[Eugen Sawin [:esawin]]

Attachment: 0003-Bug-1471599-3.0-Extend-tracking-protection-test-to-v.patch

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0002-Bug-1471599-2.0-Use-per-session-tracking-protection-.patch

Missed something.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2b2ef401f29
[1.0] Dispatch setting updates to disabled (passive) content modules. r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/50eead5ec68f
[2.0] Use per-session tracking protection setting in the example app. r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc7caa85ff1d
[3.0] Extend tracking protection test to verify per-session setting. r=snorp

Comment 6

[Chris Peterson [:cpeterson]]

Eugen, will we want to uplift these changes to GV Beta 62 for Focus 7.0?

Comment 7

[Eugen Sawin [:esawin]]

We probably want to uplift all blockers of bug 1458327. I've tried to update the dependency tree accordingly.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a2b2ef401f29
https://hg.mozilla.org/mozilla-central/rev/50eead5ec68f
https://hg.mozilla.org/mozilla-central/rev/dc7caa85ff1d

Comment 9

[Chris Peterson [:cpeterson]]

We should uplift this fix to Beta 62.

Comment 10

[Pascal Chevrel:pascalc]

Eugen, could you request the uplift to beta for this fix please? Thanks

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8988163 [details] [diff] [review]
0001-Bug-1471599-1.0-Dispatch-setting-updates-to-disabled.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1458327
[User impact if declined]: Some Fennec settings do not respond properly, such as tracking protection.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes. Ensure that turning tracking protection to "always" blocks stuff.
[List of other uplifts needed for the feature/fix]: All patches in this bug
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just avoids accidentally setting some prefs on startup
[String changes made/needed]: None

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8988163 [details] [diff] [review]
0001-Bug-1471599-1.0-Dispatch-setting-updates-to-disabled.patch

Important to have tracking protection working, let's uplift for beta 8.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ebb30b4f366
https://hg.mozilla.org/releases/mozilla-beta/rev/f45fd24c7beb
https://hg.mozilla.org/releases/mozilla-beta/rev/799e2bc3b592

Comment 14

[Oana Horvath [:ohorvath - out of office]]

Verified on Beta 62.0b9.
Device:Samsung Galaxy Tab 3 (Android 7.0)