1471628 - Make Captive Portal Service testable via xpcshell test

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

The captive portal service isn't even started when non-local connections are disabled, as it is with xpcshell-tests.
This makes it harder to test.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1471628 - Add test for Captive Portal Service

Review commit: https://reviewboard.mozilla.org/r/253454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253454/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1471628 - Use singleton for captive portal constructor

This is to make sure that the test is using the same Captive Portal Service that nsIOService initializes.

Review commit: https://reviewboard.mozilla.org/r/253502/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253502/

Comment 3

[Daniel Stenberg [:bagder]]

Comment on attachment 8988260 [details]
Bug 1471628 - Use singleton for captive portal constructor

https://reviewboard.mozilla.org/r/253502/#review260272

Comment 4

[Daniel Stenberg [:bagder]]

Comment on attachment 8988227 [details]
Bug 1471628 - Add test for Captive Portal Service

https://reviewboard.mozilla.org/r/253454/#review260276

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeec72dc70ac
Add test for Captive Portal Service r=bagder
https://hg.mozilla.org/integration/autoland/rev/f4de76c19666
Use singleton for captive portal constructor r=bagder

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (bug 1471628) for failures in netwerk/test/unit/test_captive_portal_service.js on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f4de76c196666f2fa6130fa6be4304b8463d368f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-classifiedState=unclassified&selectedJob=185322276

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185322276&repo=autoland&lineNumber=1330

Backout: https://hg.mozilla.org/integration/autoland/rev/7e6c2dbc2460bee57ecfa2f78e50f58a99848221

Comment 7

[Valentin Gosu [:valentin] (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/327de25643e2eafc6878bfc1fc39c8ceaa6d490d
Bug 1471628 - Add test for Captive Portal Service r=bagder

https://hg.mozilla.org/integration/mozilla-inbound/rev/59a408f5d9923159f01ba3ff8ccf82dfd03e1a42
Bug 1471628 - Use singleton for captive portal constructor r=bagder

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/327de25643e2
https://hg.mozilla.org/mozilla-central/rev/59a408f5d992