1471631 - simplify ServiceWorker registration listener code

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently you have to register a listener on the ServiceWorkerManager to receives updates about a particular registration.  This could be a lot more simple if we just added these listeners to the ServiceWorkerRegistrationInfo itself.

This is part of my IPC binding layer patch queue.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap

https://treeherder.mozilla.org/#/jobs?repo=try&revision=90c63126d3ed4dbb9752544cb2ec3760da20e83c

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9d6e2ff162965e6ad3dedd28a1b85466da0451f

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4556eb082327253481abb7411024e8d747e63777

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8988277 [details] [diff] [review]
Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap

This is a refactoring patch I had in my IPC patch queue.  It simplifies some of the relationship inside SWM.  Previously we stored the list of registration listeners in SWM itself and ServiceWorkerRegistrationInfo had to call out to it to update listeners.  This patch simplifies things by making listeners attach to ServiceWorkerRegistrationInfo itself.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90f2a322ea82
Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/90f2a322ea82