Closed Bug 1471631 Opened 2 years ago Closed 2 years ago
Worker registration listener code
Currently you have to register a listener on the ServiceWorkerManager to receives updates about a particular registration. This could be a lot more simple if we just added these listeners to the ServiceWorkerRegistrationInfo itself. This is part of my IPC binding layer patch queue.
Attachment #8988220 - Attachment is obsolete: true
Attachment #8988251 - Attachment is obsolete: true
Comment on attachment 8988277 [details] [diff] [review] Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap This is a refactoring patch I had in my IPC patch queue. It simplifies some of the relationship inside SWM. Previously we stored the list of registration listeners in SWM itself and ServiceWorkerRegistrationInfo had to call out to it to update listeners. This patch simplifies things by making listeners attach to ServiceWorkerRegistrationInfo itself.
Attachment #8988277 - Flags: review?(mrbkap)
Attachment #8988277 - Flags: review?(mrbkap) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/90f2a322ea82 Move ServiceWorkerManager::AddRegistrationEventListener() code to ServiceWorkerRegistrationInfo. r=mrbkap
You need to log in before you can comment on or make changes to this bug.