Closed Bug 1471632 Opened 3 years ago Closed 3 years ago

Fix angle mingw clang compilation.

Categories

(Core :: Graphics, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
It fails with:

gfx/angle/checkout/src/common/third_party/smhasher/src/PMurHash.cpp:211:12: error: cast from pointer to smaller type 'long' loses information
  int i = -(long)ptr & 3;
           ^~~~~~~~~
1 error generated.
Crash Signature: It fails with: gfx/angle/checkout/src/common/third_party/smhasher/src/PMurHash.cpp:211:12: error: cast from pointer to smaller type 'long' loses information int i = -(long)ptr & 3; ^~~~~~~~~ 1 error generated.
I submitted the patch upstream:
https://chromium-review.googlesource.com/c/angle/angle/+/1117187
It's committed upstream, so m-c will have it after the next angle update. The attached patch is for esr60.
Attachment #8988222 - Flags: review?(jmuizelaar) → review?(jgilbert)
Comment on attachment 8988222 [details]
Bug 1471632 - Fix angle mingw clang compilation.

https://reviewboard.mozilla.org/r/253458/#review263840

This is fine, but all patches against in-tree ANGLE need to go through github.com/mozilla/angle and be vendored into the tree anew.
I'll handle this.
Attachment #8988222 - Flags: review?(jgilbert) → review-
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6b2cc9818f9
Cherry-pick mingw clang compilation fix.
https://hg.mozilla.org/mozilla-central/rev/f6b2cc9818f9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.