1471632 - Fix angle mingw clang compilation.

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P2)

Comment 1

[Jacek Caban]

It fails with:

gfx/angle/checkout/src/common/third_party/smhasher/src/PMurHash.cpp:211:12: error: cast from pointer to smaller type 'long' loses information
  int i = -(long)ptr & 3;
           ^~~~~~~~~
1 error generated.

Comment 2

[Jacek Caban]

Attachment: Bug 1471632 - Fix angle mingw clang compilation.

Review commit: https://reviewboard.mozilla.org/r/253458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253458/

Comment 3

[Jacek Caban]

I submitted the patch upstream:
https://chromium-review.googlesource.com/c/angle/angle/+/1117187

Comment 4

[Jacek Caban]

Comment on attachment 8988222 [details]
Bug 1471632 - Fix angle mingw clang compilation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253458/diff/1-2/

Comment 5

[Jacek Caban]

It's committed upstream, so m-c will have it after the next angle update. The attached patch is for esr60.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8988222 [details]
Bug 1471632 - Fix angle mingw clang compilation.

https://reviewboard.mozilla.org/r/253458/#review263840

This is fine, but all patches against in-tree ANGLE need to go through github.com/mozilla/angle and be vendored into the tree anew.
I'll handle this.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1471632 - Cherry-pick mingw clang compilation fix.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6b2cc9818f9
Cherry-pick mingw clang compilation fix.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f6b2cc9818f9