1471638 - --enable-fuzzing coverage build is inconsistently named.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Jesse Schwartzentruber (:truber)]

linux64-fuzzing-asan-opt-cov should be named either:
  linux64-fuzzing-ccov-asan-opt or
  linux64-ccov-fuzzing-asan-opt
for consistency with other builds.

-cov is not used for any other coverage builds, and breaks tools like https://github.com/MozillaSecurity/fuzzfetch which look for -ccov in the namespace.

Comment 1

[Raymond Forbes[:rforbes]]

Attachment: bug 1471638 - fix name for coverage fuzzing build

Review commit: https://reviewboard.mozilla.org/r/253530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/253530/

Comment 2

[Marco Castelluccio [:marco]]

Comment on attachment 8988264 [details]
bug 1471638 - fix name for coverage fuzzing build

https://reviewboard.mozilla.org/r/253530/#review260176

::: taskcluster/ci/build/linux.yml:615
(Diff revision 1)
>          config:
>              - builds/releng_base_firefox.py
>              - builds/releng_base_linux_64_builds.py
>          script: "mozharness/scripts/fx_desktop_build.py"
>          secrets: true
>          custom-build-variant-cfg: fuzzing-cov

Do you want to change this too? I guess it doesn't matter for tools like fuzzfetch though.

Comment 3

[Jesse Schwartzentruber (:truber)]

I downloaded the build from this changeset on try using fuzzfetch and it's recognized as a coverage build. Thanks!

Comment 4

[Raymond Forbes[:rforbes]]

Comment on attachment 8988264 [details]
bug 1471638 - fix name for coverage fuzzing build

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253530/diff/1-2/

Comment 5

[Raymond Forbes[:rforbes]]

Comment on attachment 8988264 [details]
bug 1471638 - fix name for coverage fuzzing build

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/253530/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a6be4e929e3
fix name for coverage fuzzing build r=marco

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0a6be4e929e3