Closed Bug 1471638 Opened 4 years ago Closed 4 years ago

--enable-fuzzing coverage build is inconsistently named.

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: truber, Assigned: rforbes)

References

Details

Attachments

(1 file)

bug 1471638 - fix name for coverage fuzzing build
59 bytes, text/x-review-board-request
marco
: review+
Details 
linux64-fuzzing-asan-opt-cov should be named either:
  linux64-fuzzing-ccov-asan-opt or
  linux64-ccov-fuzzing-asan-opt
for consistency with other builds.

-cov is not used for any other coverage builds, and breaks tools like https://github.com/MozillaSecurity/fuzzfetch which look for -ccov in the namespace.
Comment on attachment 8988264 [details]
bug 1471638 - fix name for coverage fuzzing build

https://reviewboard.mozilla.org/r/253530/#review260176

::: taskcluster/ci/build/linux.yml:615
(Diff revision 1)
>          config:
>              - builds/releng_base_firefox.py
>              - builds/releng_base_linux_64_builds.py
>          script: "mozharness/scripts/fx_desktop_build.py"
>          secrets: true
>          custom-build-variant-cfg: fuzzing-cov

Do you want to change this too? I guess it doesn't matter for tools like fuzzfetch though.
Attachment #8988264 - Flags: review?(mcastelluccio) → review+
I downloaded the build from this changeset on try using fuzzfetch and it's recognized as a coverage build. Thanks!
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a6be4e929e3
fix name for coverage fuzzing build r=marco
https://hg.mozilla.org/mozilla-central/rev/0a6be4e929e3
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.