Closed
Bug 1471664
Opened 7 years ago
Closed 7 years ago
Remove redundant code for creating userData in SetupLineBreakerContext
Categories
(Core :: Layout: Text and Fonts, enhancement, P3)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
Attachments
(1 file)
2.89 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
In BuildTextRunsScanner::SetupLineBreakerContext, we don't need to create a userData to keep track of mapped flows in the textrun, as this has already been done by BuildTextRunForFrames. So the potential allocation of a userData record is redundant here.
Assignee | ||
Comment 1•7 years ago
|
||
This reduces the size of libxul in my local (opt) build by about 4K.
Attachment #8988256 -
Flags: review?(xidorn+moz)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
Comment on attachment 8988256 [details] [diff] [review]
Remove redundant code for creating userData in SetupLineBreakerContext
Review of attachment 8988256 [details] [diff] [review]:
-----------------------------------------------------------------
IIUC, the code being removed here has no effect at all as themselves? They don't seem to have any side effect other than the allocation.
Attachment #8988256 -
Flags: review?(xidorn+moz) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Right, it's completely pointless and has no effect on anything; just wasted cycles.
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0413702a1dc9
Remove redundant code for creating userData in SetupLineBreakerContext. r=xidorn
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•