1471664 - Remove redundant code for creating userData in SetupLineBreakerContext

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement, P3)

Description

[Jonathan Kew [:jfkthame]]

In BuildTextRunsScanner::SetupLineBreakerContext, we don't need to create a userData to keep track of mapped flows in the textrun, as this has already been done by BuildTextRunForFrames. So the potential allocation of a userData record is redundant here.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Remove redundant code for creating userData in SetupLineBreakerContext

This reduces the size of libxul in my local (opt) build by about 4K.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8988256 [details] [diff] [review]
Remove redundant code for creating userData in SetupLineBreakerContext

Review of attachment 8988256 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC, the code being removed here has no effect at all as themselves? They don't seem to have any side effect other than the allocation.

Comment 3

[Jonathan Kew [:jfkthame]]

Right, it's completely pointless and has no effect on anything; just wasted cycles.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0413702a1dc9
Remove redundant code for creating userData in SetupLineBreakerContext. r=xidorn

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0413702a1dc9