1471943 - NetworkInfoServiceLinux.cpp: Possible socket resource leak

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, defect, P3)

Description

[Robert Bartlensky [:rbartlensky]]

The infer static analyzer reported a resource leak here: https://searchfox.org/mozilla-central/source/netwerk/base/NetworkInfoServiceLinux.cpp#64 and I think it might be right.

The autoCloseSocket is defined at https://searchfox.org/mozilla-central/source/netwerk/base/NetworkInfoServiceLinux.cpp#34-36 and it is a ScopeExit object. In this case it holds a file descriptor, and when it goes out of scope runs the system call close.

If the execution manages to reach https://searchfox.org/mozilla-central/source/netwerk/base/NetworkInfoServiceLinux.cpp#64 the ScopeExit object will no longer free the resource (because the release method sets a variable which makes the destructor skip the freeing of the resource), thus causing a resource leak.

It can be seen here: https://searchfox.org/mozilla-central/source/netwerk/base/NetworkInfoServiceLinux.cpp#57,69 that the file descriptor is passed to another function before executing the line in question, but the file descriptor is not closed anywhere.

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1471943: Remove release call to ensure socket is closed.

Review commit: https://reviewboard.mozilla.org/r/254250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254250/

Comment 2

[Andi [:andi]]

I think valentin should take care of this review, since he's the reviewer for this component.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8989198 [details]
Bug 1471943: Remove release call to ensure socket is closed.

https://reviewboard.mozilla.org/r/254250/#review261584

That's a good catch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d53abfceeac2
Remove release call to ensure socket is closed. r=valentin

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d53abfceeac2

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d53abfceeac2