1472145 - Add telemetry to determine how frequently WebP content is incorrectly served

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

There are a number of webcompat issues filed against bug 1294490. I would like to get a sense of how many users this is affecting today. I assume it is predominantly Fennec where websites incorrectly assume Android implies WebP support.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1472145-Part-1.-Add-support-for-identifying-the-.patch, v1

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0002-Bug-1472145-Part-2.-Add-telemetry-to-track-how-frequ.patch, v1

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Request for data collection.txt, v1

chutten, FYI I want to collect this for both desktop and fennec, although I expect fennec is where the bulk of the useful data is, given the webcompat issues filed all seem to be against it.

Comment 4

[Chris H-C :chutten]

Comment on attachment 8988830 [details]
Request for data collection.txt, v1

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. Standard Telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. Standard Telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?**

N/A expires in 65 (last version with recordings will be 64)

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **

Category 1 (theoretically category 2 since we record the _number_ of images loaded, but that's almost a technical detail in today's web so *shrug*)

    Is the data collection request for default-on or default-off?

Default on.

    Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

It introduces the two strings "webp" and "other". These are just category labels.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :aosmond is responsible for evaluating whether to renew or remove this collection before it expires at the end of Firefox 64.

---
Result: datareview+

Comment 5

[Chris H-C :chutten]

Firefox for Android and Firefox on Desktop both fall under the Firefox Privacy Notice, so collection against either is handled the same way :)

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=872f66950de16d1e17b5ded1d7921de972db1934

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a57944df012
Part 1. Add support for identifying the WebP images MIME type. r=tnikkel
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1f4fe78843
Part 2. Add telemetry to track how frequently WebP images are used. r=tnikkel data-r=chutten

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2a57944df012
https://hg.mozilla.org/mozilla-central/rev/8d1f4fe78843

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/546b7b24b71b
Part 3. Initialize boolean WebP telemetry scalars to ensure accurate reporting. r=aosmond

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/546b7b24b71b

Comment 11

[Andrew Osmond [:aosmond] (he/him)]

Attachment: [beta] 0001-Bug-1472145-Part-1.-Add-support-for-identifying-the-.patch, v1 [carries r=tnikkel, data-r=chutten]

Comment 12

[Andrew Osmond [:aosmond] (he/him)]

Attachment: [beta] 0002-Bug-1472145-Part-2.-Add-telemetry-to-track-how-frequ.patch, v1 [carries r=tnikkel, data-r=chutten]

I would very much like to uplift these two patches to beta. Otherwise we won't have any Android numbers until mid fall due to how few nightly users there are on Android.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=adfdd7fe8c1f975e3a0fde3774853126ef9496fb

Comment 13

[Mike Gifford]

Just ran into this new ebook from Smashing Magazine:
  https://www.smashingmagazine.com/ebooks/the-webp-manual/

Looks like FF still isn't supporting WebP:
  https://developers.google.com/speed/webp/gallery1

Any ETA when it will come bundled by default in FF (desktop & mobile)?

Comment 14

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Mike Gifford from comment #13)
> Just ran into this new ebook from Smashing Magazine:
>   https://www.smashingmagazine.com/ebooks/the-webp-manual/
> 
> Looks like FF still isn't supporting WebP:
>   https://developers.google.com/speed/webp/gallery1
> 
> Any ETA when it will come bundled by default in FF (desktop & mobile)?

This bug just added some telemetry probes to collect some data on how frequently Firefox users are encountering WebP. No implementation support for WebP. Currently only data is showing on telemetry.mozilla.org for desktop, but what I'm really hoping for are numbers on Android to help our decision making.

Comment 15

[Marco Sousa]

Why there aren't any data from Android?

I personaly install the last Firefox nightly on Android on 2018/07/25 and I navigate to https://developers.google.com/speed/webp/gallery

Show it should be any data by now.