Closed
Bug 1472220
Opened 6 years ago
Closed 6 years ago
Back out Bug 1453691 (google / facebook UA spoofing addon)
Categories
(Web Compatibility :: Tooling & Investigations, enhancement, P1)
Web Compatibility
Tooling & Investigations
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: miketaylr, Assigned: twisniewski)
References
Details
Attachments
(1 file)
Once the addon from Bug 1453691 has been in Nightly for 4 weeks, we can back it out. Possible outcomes, depending on results / bugs found: * start up conversations with Google search team again * add a permanent UA override * do nothing
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P1
|
|
Reporter | |
Comment 1•6 years ago
|
||
Update: not sure exactly when we want to back this out, but July 27 it ain't.
|
|
Reporter | |
Comment 2•6 years ago
|
||
Tom, if we can't figure out the pile of offline GWS issues today, rather than back this out, let's land a patch that disables the addon via a pref flip.
Flags: needinfo?(wisniewskit)
|
||
Updated•6 years ago
|
Flags: needinfo?(wisniewskit)
|
|
Reporter | |
Comment 3•6 years ago
|
||
Google is sending us the nicer tier 2 experience to release at this point, so I think we can back this out now.
|
|
Reporter | |
Updated•6 years ago
|
Summary: Back out Bug 1453691 (google / facebook UA spoofing addon) on July 27 → Back out Bug 1453691 (google / facebook UA spoofing addon)
|
Assignee | |
Comment 4•6 years ago
|
||
back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691
|
|
Assignee | |
Comment 5•6 years ago
|
||
Patch is now ready for review. I don't see any try-run build problems: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62b958ca7a1d134b4724cb094411727d5714fe06 But note that we just shouldn't actually land this until we're sure everyone is getting the new tier 2 experience (I'm not seeing it yet on my own phone in Canada).
|
||
Comment 6•6 years ago
|
||
Comment on attachment 9009705 [details] Bug 1472220 - back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r?rhelmer Robert Helmer [:rhelmer] has approved the revision.
Attachment #9009705 -
Flags: review+
|
|
Assignee | |
Comment 7•6 years ago
|
||
We've decided to go ahead with this now, so I've rebased the patch and am requesting check-in.
Keywords: checkin-needed
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83eda6b67672 back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r=rhelmer
Keywords: checkin-needed
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/83eda6b67672
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•