1472220 - Back out Bug 1453691 (google / facebook UA spoofing addon)

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, enhancement, P1)

Description

[Mike Taylor [:miketaylr]]

Once the addon from Bug 1453691 has been in Nightly for 4 weeks, we can back it out.

Possible outcomes, depending on results / bugs found:

* start up conversations with Google search team again
* add a permanent UA override 
* do nothing

Comment 1

[Mike Taylor [:miketaylr]]

Update: not sure exactly when we want to back this out, but July 27 it ain't.

Comment 2

[Mike Taylor [:miketaylr]]

Tom, if we can't figure out the pile of offline GWS issues today, rather than back this out, let's land a patch that disables the addon via a pref flip.

Comment 3

[Mike Taylor [:miketaylr]]

Google is sending us the nicer tier 2 experience to release at this point, so I think we can back this out now.

Comment 4

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1472220 - back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r?rhelmer

back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691

Comment 5

[Thomas Wisniewski [:twisniewski]]

Patch is now ready for review.

I don't see any try-run build problems: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62b958ca7a1d134b4724cb094411727d5714fe06

But note that we just shouldn't actually land this until we're sure everyone is getting the new tier 2 experience (I'm not seeing it yet on my own phone in Canada).

Comment 6

[Robert Helmer [:rhelmer]]

Comment on attachment 9009705 [details]
Bug 1472220 - back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r?rhelmer

Robert Helmer [:rhelmer] has approved the revision.

Comment 7

[Thomas Wisniewski [:twisniewski]]

We've decided to go ahead with this now, so I've rebased the patch and am requesting check-in.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83eda6b67672
back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r=rhelmer

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/83eda6b67672