Back out Bug 1453691 (google / facebook UA spoofing addon)

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
9 months ago
6 months ago

People

(Reporter: miketaylr, Assigned: twisniewski)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Once the addon from Bug 1453691 has been in Nightly for 4 weeks, we can back it out.

Possible outcomes, depending on results / bugs found:

* start up conversations with Google search team again
* add a permanent UA override 
* do nothing
Priority: -- → P1
Update: not sure exactly when we want to back this out, but July 27 it ain't.
Tom, if we can't figure out the pile of offline GWS issues today, rather than back this out, let's land a patch that disables the addon via a pref flip.
Flags: needinfo?(wisniewskit)

Updated

7 months ago
Flags: needinfo?(wisniewskit)
Google is sending us the nicer tier 2 experience to release at this point, so I think we can back this out now.
Summary: Back out Bug 1453691 (google / facebook UA spoofing addon) on July 27 → Back out Bug 1453691 (google / facebook UA spoofing addon)
(Assignee)

Comment 4

6 months ago
back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691
(Assignee)

Comment 5

6 months ago
Patch is now ready for review.

I don't see any try-run build problems: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62b958ca7a1d134b4724cb094411727d5714fe06

But note that we just shouldn't actually land this until we're sure everyone is getting the new tier 2 experience (I'm not seeing it yet on my own phone in Canada).
Comment on attachment 9009705 [details]
Bug 1472220 - back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r?rhelmer

Robert Helmer [:rhelmer] has approved the revision.
Attachment #9009705 - Flags: review+
(Assignee)

Comment 7

6 months ago
We've decided to go ahead with this now, so I've rebased the patch and am requesting check-in.
Keywords: checkin-needed

Comment 8

6 months ago
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83eda6b67672
back out the Fennec GWS/Facebook UA-spoofing system addon added in bug 1453691; r=rhelmer
Keywords: checkin-needed

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/83eda6b67672
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.