Closed Bug 1472280 Opened 2 years ago Closed 2 years ago

Improve "lastTestSeen" string

Categories

(Testing :: Mochitest, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently mochitest looks for a test_start log action and stores the name of the test in an instance variable. In the event of a timeout/hang, this string is used in the log to help people try and narrow down where it happened.

However, there a couple cases it can be misleading:
1) If the hang happens during shutdown, it looks like it was the last test's fault (it probably isn't)
2) If the hang happens in-between tests, it looks like the test timed out

We should make the string more descriptive. I propose that when we get a test_end action, we change it to <test> (finished). And when we get the test end action of the last test, we change it to "Last test finished".

This way it narrows down where the hang happened even further.
Currently mochitest looks for a test_start log action and stores the name of
the test in an instance variable. In the event of a timeout/hang, this string
is used in the log to help people try and narrow down where it happened.

However, there are a couple cases it can be misleading:
1) If the hang happens during shutdown, it looks like it was the last test's fault (it probably isn't)
2) If the hang happens in-between tests, it looks like the test timed out

We should make the string more descriptive. I propose that when we get a
test_end action, we change it to <test> (finished). And when we get the test
end action of the last test, we change it to "Last test finished".

This way it narrows down where the hang happened even further.

MozReview-Commit-ID: B6g8JrIJuJw
Assignee: nobody → ahal
Status: NEW → ASSIGNED
Comment on attachment 8988815 [details]
Bug 1472280 - [mochitest] Provide better 'lastTestSeen' strings to differentiate the end of a test

Joel Maher ( :jmaher ) (UTC-4) has approved the revision.

https://phabricator.services.mozilla.com/D1885
Attachment #8988815 - Flags: review+
Blocks: 1472493
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ca122297962
[mochitest] Provide better 'lastTestSeen' strings to differentiate the end of a test r=jmaher
https://hg.mozilla.org/mozilla-central/rev/0ca122297962
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.