1472280 - Improve "lastTestSeen" string

Status: RESOLVED FIXED

(Testing :: Mochitest, enhancement)

Description

[Andrew Halberstadt [:ahal]]

Currently mochitest looks for a test_start log action and stores the name of the test in an instance variable. In the event of a timeout/hang, this string is used in the log to help people try and narrow down where it happened.

However, there a couple cases it can be misleading:
1) If the hang happens during shutdown, it looks like it was the last test's fault (it probably isn't)
2) If the hang happens in-between tests, it looks like the test timed out

We should make the string more descriptive. I propose that when we get a test_end action, we change it to <test> (finished). And when we get the test end action of the last test, we change it to "Last test finished".

This way it narrows down where the hang happened even further.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1472280 - [mochitest] Provide better 'lastTestSeen' strings to differentiate the end of a test

Currently mochitest looks for a test_start log action and stores the name of
the test in an instance variable. In the event of a timeout/hang, this string
is used in the log to help people try and narrow down where it happened.

However, there are a couple cases it can be misleading:
1) If the hang happens during shutdown, it looks like it was the last test's fault (it probably isn't)
2) If the hang happens in-between tests, it looks like the test timed out

We should make the string more descriptive. I propose that when we get a
test_end action, we change it to <test> (finished). And when we get the test
end action of the last test, we change it to "Last test finished".

This way it narrows down where the hang happened even further.

MozReview-Commit-ID: B6g8JrIJuJw

Comment 2

[Phabricator Automation]

Comment on attachment 8988815 [details]
Bug 1472280 - [mochitest] Provide better 'lastTestSeen' strings to differentiate the end of a test

Joel Maher ( :jmaher ) (UTC-4) has approved the revision.

https://phabricator.services.mozilla.com/D1885

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ca122297962
[mochitest] Provide better 'lastTestSeen' strings to differentiate the end of a test r=jmaher

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0ca122297962