1472286 - Fix checks for legacy themes

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1472286 - Stop appending @personas.mozilla.org suffix for built-in themes.

Review commit: https://reviewboard.mozilla.org/r/254002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254002/

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1472286 - Fix checks for legacy themes.

Review commit: https://reviewboard.mozilla.org/r/254004/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254004/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8988846 [details]
Bug 1472286 - Stop appending @personas.mozilla.org suffix for built-in themes.

https://reviewboard.mozilla.org/r/254002/#review260802

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8988847 [details]
Bug 1472286 - Fix checks for legacy themes.

https://reviewboard.mozilla.org/r/254004/#review260804

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc9cfde75af6
Stop appending @personas.mozilla.org suffix for built-in themes. r=kmag
https://hg.mozilla.org/integration/autoland/rev/914241e649a0
Fix checks for legacy themes. r=kmag

Comment 6

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1472286) for Browser chrome failures on toolkit/mozapps/extensions/test/browser/browser_legacy_themes.js

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=185702772&repo=autoland

TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js | Element should not be null, when checking visibility - 
[task 2018-06-30T00:30:55.652Z]     INFO - Buffered messages finished
[task 2018-06-30T00:30:55.656Z]     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js | Legacy badge is visible for Full Theme - 
[task 2018-06-30T00:30:55.657Z]     INFO - Stack trace:
[task 2018-06-30T00:30:55.657Z]     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:is_element_visible:505
[task 2018-06-30T00:30:55.658Z]     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js:check:66
[task 2018-06-30T00:30:55.658Z]     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js:null:90
[task 2018-06-30T00:30:55.659Z]     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
[task 2018-06-30T00:30:55.659Z]     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
[task 2018-06-30T00:30:55.660Z]     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:991
[task 2018-06-30T00:30:55.660Z]     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-06-30T00:30:55.660Z]     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js | Legacy badge link is correct - 
[task 2018-06-30T00:30:55.661Z]     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js | Found the legacy-warning element - 
[task 2018-06-30T00:30:55.662Z]     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js | Element should not be null, when checking visibility - 
[task 2018-06-30T00:30:55.662Z]     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-06-30T00:30:55.664Z]     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js | Legacy badge is visible for Full Theme - 
[task 2018-06-30T00:30:55.664Z]     INFO - Stack trace:
[task 2018-06-30T00:30:55.665Z]     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:is_element_visible:505
[task 2018-06-30T00:30:55.666Z]     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js:check:83
[task 2018-06-30T00:30:55.666Z]     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js:null:90
[task 2018-06-30T00:30:55.667Z]     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098
[task 2018-06-30T00:30:55.667Z]     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089
[task 2018-06-30T00:30:55.667Z]     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:991
[task 2018-06-30T00:30:55.668Z]     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-06-30T00:30:55.672Z]     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_legacy_pre57.js | Legacy badge link is correct - 

Failures push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=914241e649a03e077d26394b396ef810d9be7beb

Backout:
https://hg.mozilla.org/integration/autoland/rev/5540e1b64aa27358f495b8842ba6857b393be203

Comment 7

[Kris Maglione [:kmag]]

Urgh, sorry, I should have seen that coming.

Please just delete browser_legacy_themes.js, and the legacy theme entries from browser_legacy_pre57.js. They use a mock provider, which is the only reason they can hit this. The real built-in providers never return legacy themes anymore.

Comment 8

[Tim Nguyen :ntim]

Thanks Kris, will take care of it!

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 8988847 [details]
Bug 1472286 - Fix checks for legacy themes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254004/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80c2ae825771
Stop appending @personas.mozilla.org suffix for built-in themes. r=kmag
https://hg.mozilla.org/integration/autoland/rev/a8466a8972cd
Fix checks for legacy themes. r=kmag

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/80c2ae825771
https://hg.mozilla.org/mozilla-central/rev/a8466a8972cd