Closed Bug 1472426 Opened 2 years ago Closed Last year

[FIX] HTMLFormElement.cpp should probably use IsInComposedDoc

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Priority: -- → P3
Assignee: nobody → bugs
ended up writing a new simple test using the same backend which test_formSubmission.html has.
In the code there is just one IsInUncomposedDoc -> IsInComposedDoc change.

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/123eab83f4d03abce0cbbd2c211f1c6925108b66
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=123eab83f4d03abce0cbbd2c211f1c6925108b66
remote: recorded changegroup in replication log in 0.097s
Attachment #8989730 - Flags: review?(amarchesini)
Summary: HTMLFormElement.cpp should probably use IsInComposedDoc → [FIX] HTMLFormElement.cpp should probably use IsInComposedDoc
Comment on attachment 8989730 [details] [diff] [review]
formcontrol_isincomposedoc.diff

Review of attachment 8989730 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/test/test_bug1472426.html
@@ +28,5 @@
> +              .replace(/\r/g, " ")
> +              .replace(/\n/g, " ")
> +              .replace(/\"/g, "\\\"");
> +    }
> +  

extra space here and elsewhere in this file.

@@ +117,5 @@
> +  </template>
> +</head>
> +<body>
> +<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1472426">Mozilla Bug 1472426</a>
> +<p id="display"></p>

remove this <p>, the following <div> and the following <pre>
Attachment #8989730 - Flags: review?(amarchesini) → review+
FWIW, I just use the template generator when creating test files, and it adds all sorts of stuff.
And when using it, it isn't clear what elements are needed by mochitest framework.
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f60f27d4d133
form submission should work in shadow DOM, r=baku
https://hg.mozilla.org/mozilla-central/rev/f60f27d4d133
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.