Closed
Bug 1472426
Opened 6 years ago
Closed 6 years ago
[FIX] HTMLFormElement.cpp should probably use IsInComposedDoc
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
6.42 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
6.31 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bugs
|
|
Assignee | |
Comment 1•6 years ago
|
||
ended up writing a new simple test using the same backend which test_formSubmission.html has. In the code there is just one IsInUncomposedDoc -> IsInComposedDoc change. remote: View your change here: remote: https://hg.mozilla.org/try/rev/123eab83f4d03abce0cbbd2c211f1c6925108b66 remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=123eab83f4d03abce0cbbd2c211f1c6925108b66 remote: recorded changegroup in replication log in 0.097s
Attachment #8989730 -
Flags: review?(amarchesini)
|
|
Assignee | |
Updated•6 years ago
|
Summary: HTMLFormElement.cpp should probably use IsInComposedDoc → [FIX] HTMLFormElement.cpp should probably use IsInComposedDoc
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8989730 [details] [diff] [review] formcontrol_isincomposedoc.diff Review of attachment 8989730 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/html/test/test_bug1472426.html @@ +28,5 @@ > + .replace(/\r/g, " ") > + .replace(/\n/g, " ") > + .replace(/\"/g, "\\\""); > + } > + extra space here and elsewhere in this file. @@ +117,5 @@ > + </template> > +</head> > +<body> > +<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1472426">Mozilla Bug 1472426</a> > +<p id="display"></p> remove this <p>, the following <div> and the following <pre>
Attachment #8989730 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
FWIW, I just use the template generator when creating test files, and it adds all sorts of stuff.
|
|
Assignee | |
Comment 4•6 years ago
|
||
And when using it, it isn't clear what elements are needed by mochitest framework.
|
|
Assignee | |
Comment 5•6 years ago
|
||
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f60f27d4d133 form submission should work in shadow DOM, r=baku
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f60f27d4d133
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•