1472427 - [FIX] HTMLImageElement.cpp should use IsInComposedDoc and GetUseMap should be fixed for work in Shadow DOM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: usemap_in_shadowdom.diff

This is a bit larger patch. Moving image map handling from nsIDocument to nsImageLoadingContent since that is what nsImageFrame after all expects
(it gets usemap attribute value from mContent and then gets the image map stuff).
We do create temporary nsContentList for usemap images in shadow DOM, but it isn't live list, and usemaps should be very rare.

In general our usemap handling is rather inconsistent, but I'm _not_ trying to fix that here. (though fixing the inconsistencies may become easier after the patch)

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/6d91419cdb3eaf8fcbfcdc7dd7dfb16d7487da83
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d91419cdb3eaf8fcbfcdc7dd7dfb16d7487da83
remote: recorded changegroup in replication log in 0.109s

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

and wrong tryserver push :/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/3b85bffc5b58692f09f974efca89fba8669063af
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b85bffc5b58692f09f974efca89fba8669063af
remote: recorded changegroup in replication log in 0.102s

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8989574 [details] [diff] [review]
usemap_in_shadowdom.diff

See comment 1 for explanation.

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8989574 [details] [diff] [review]
usemap_in_shadowdom.diff

Review of attachment 8989574 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsImageLoadingContent.cpp
@@ +1757,5 @@
> +  int32_t hash = useMap.FindChar('#');
> +  if (hash < 0) {
> +    return nullptr;
> +  }
> +  // aUsemap contains a '#', set start to point right after the '#'

aUseMap -> useMap

@@ +1761,5 @@
> +  // aUsemap contains a '#', set start to point right after the '#'
> +  start.advance(hash + 1);
> +
> +  if (start == end) {
> +    return nullptr; // aUsemap == "#"

aUseMap -> useMap

@@ +1794,5 @@
> +  }
> +
> +  return nullptr;
> +}
> +

no extra line here.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: usemap_in_shadowdom_2.diff

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcc1e5fa1c42
<img usemap> should work in shadow DOM, r=baku

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fcc1e5fa1c42