1472470 - [Session Restore] Large session state is not recorded to recovery.jsonlz4 without warning

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect, P3)

Description

[John Drinkwater (:beta)]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180625141512

Steps to reproduce:

Fail to close tabs because I am bad at getting things done™

A browser restart a few weeks ago lost a few days of recent tabs, and i’ve been trying to reproduce why, so here we go.
Limit seems to be around 8.8MB for the {sessionstore,previous,recovery}.jsonlz4 files, though it could be entry limit rather than data size being the cause.


Actual results:

Noticed that the session recovery file wasn’t being updated:
-rw------- 1 john 8.7M 2018-06-29 19:39 previous.jsonlz4
-rw------- 1 john 8.8M 2018-06-30 13:05 recovery.baklz4
-rw------- 1 john 8.8M 2018-06-30 13:05 recovery.jsonlz4

Until I closed a few tabs and then it restarted:
-rw------- 1 john 8.8M 2018-06-30 15:57 recovery.baklz4
-rw------- 1 john 8.8M 2018-06-30 15:57 recovery.jsonlz4
[…]
-rw------- 1 john 8.8M 2018-06-30 16:04 recovery.baklz4
-rw------- 1 john 8.8M 2018-06-30 16:05 recovery.jsonlz4



Expected results:

Session state correctly stored, or user presented with situation - and possible an intervention to convince user to bookmark and close tabs.

Bug 1034038 exists to make a method of informing the user about any session storage issue, but looks to have never been completed. Created this bug to have a user-error reason to cite on that report.

Comment 1

[Dale Harvey (:daleharvey)]

Cheers for the info, that seems like enough info to go on

Comment 2

[Mike de Boer [:mikedeboer]]

John, this file size limit is not imposed by session store code, so this must be some setting on your machine that may be interfering. Are you using disk quota?

I don't think that 8.8M is very large, I've seen much, much larger; session store should be more than able to handle this amount of data.

Comment 3

[John Drinkwater (:beta)]

Apologies, I didn’t see a request for more info.

No disk quota was in place, have a fairly beefy resource of 16GB RAM, and not too many extensions (noscript, privacybadger, greasemonkey, stylus, and a youtube themer), and it consistently had an issue around the amount of tabs I had open.
Never assumed it was a filesize limit but possibly an interaction with stringification since it is compressed json.

I’ve been trying to be better since with far fewer tabs, so have not been reproducing this issue since.
Probably resolve as invalid?

Comment 4

[Mike de Boer [:mikedeboer]]

John, thanks for your response! Well, I still think and am sure that sessionstore is/ should be able to deal with any arbitrary amount of tabs, so I think it's worth keeping an eye out.

So in the future, please feel free to file a new bug with hopefully STR that allows us to trace down the bug!