1472535 - Put the main menu tracking protection toggle behind a pref

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

There were some discussions about UX consistency of the main menu TP toggle. If/when we introduce a less powerful blocking feature as the default it should have this spot, but we don't want to hide the TP toggle again after introducing it to users. It might be preferable to delay shipping this to release users, instead.

Hence, we would like to be able to control the exposure of the global tracking protection toggle with a pref, for when product and UX make up their minds about this.

Comment 1

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98e3559504754c6ff329eb3e92dd1fefb2a6394e

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1472535 - Put the main menu tracking protection toggle behind a pref.

This is assuming we want to pref off for 62 and pref on again for 63, simply delaying the feature by one release.

Review commit: https://reviewboard.mozilla.org/r/255768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255768/

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8990684 [details]
Bug 1472535 - Put the main menu tracking protection toggle behind a pref.

https://reviewboard.mozilla.org/r/255768/#review263362

I also hope that UX/ Product realize that hopping between ideas/ opinions and indecisiveness is not free, which this demonstrates. Sorry you have to spend time on this.

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s cb19e19bb35b624b3baf8a074ebd461a896c216d -d 5eea82f8593d: rebasing 472480:cb19e19bb35b "Bug 1472535 - Put the main menu tracking protection toggle behind a pref. r=mikedeboer" (tip)
merging browser/app/profile/firefox.js
merging browser/base/content/browser-trackingprotection.js
warning: conflicts while merging browser/base/content/browser-trackingprotection.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Johann Hofmann [:johannh]]

(In reply to Mike de Boer [:mikedeboer] from comment #3)
> Comment on attachment 8990684 [details]
> Bug 1472535 - Put the main menu tracking protection toggle behind a pref.
> 
> https://reviewboard.mozilla.org/r/255768/#review263362
> 
> I also hope that UX/ Product realize that hopping between ideas/ opinions
> and indecisiveness is not free, which this demonstrates. Sorry you have to
> spend time on this.

Thank you Mike and I agree 100%

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8990684 [details]
Bug 1472535 - Put the main menu tracking protection toggle behind a pref.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255768/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9425042ce284
Put the main menu tracking protection toggle behind a pref. r=mikedeboer

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9425042ce284

Comment 9

[Johann Hofmann [:johannh]]

Peter, I haven't uplifted this yet to allow for the planning/design of the 63 UI and how that would impact things.

Bryan mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1468318#c4 that he thinks we'll disable the toggle in 62. Given the current state of things, do you agree we should uplift this and disable the main menu tracking protection toggle?

Comment 10

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm the "privacy.trackingprotection.appMenuToggle.enabled" pref code was implemented on Nightly. I verified using Fx 63.0a1 (build ID: 20180723100101) on Windows 10 x64, Ubuntu 14.04 LTS and mac OS 10.13.5.

Comment 11

[Peter Dolanjski [:pdol]]

Deferring this decision to Bryan/Ryan.