Put the main menu tracking protection toggle behind a pref

VERIFIED FIXED in Firefox 63

Status

()

enhancement
P1
normal
VERIFIED FIXED
11 months ago
8 months ago

People

(Reporter: johannh, Assigned: johannh, NeedInfo)

Tracking

(Blocks 1 bug)

unspecified
Firefox 63
Points:
---

Firefox Tracking Flags

(firefox61 unaffected, firefox62 ?, firefox63 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
There were some discussions about UX consistency of the main menu TP toggle. If/when we introduce a less powerful blocking feature as the default it should have this spot, but we don't want to hide the TP toggle again after introducing it to users. It might be preferable to delay shipping this to release users, instead.

Hence, we would like to be able to control the exposure of the global tracking protection toggle with a pref, for when product and UX make up their minds about this.
Comment hidden (mozreview-request)

Comment 3

10 months ago
mozreview-review
Comment on attachment 8990684 [details]
Bug 1472535 - Put the main menu tracking protection toggle behind a pref.

https://reviewboard.mozilla.org/r/255768/#review263362

I also hope that UX/ Product realize that hopping between ideas/ opinions and indecisiveness is not free, which this demonstrates. Sorry you have to spend time on this.
Attachment #8990684 - Flags: review?(mdeboer) → review+

Comment 4

10 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s cb19e19bb35b624b3baf8a074ebd461a896c216d -d 5eea82f8593d: rebasing 472480:cb19e19bb35b "Bug 1472535 - Put the main menu tracking protection toggle behind a pref. r=mikedeboer" (tip)
merging browser/app/profile/firefox.js
merging browser/base/content/browser-trackingprotection.js
warning: conflicts while merging browser/base/content/browser-trackingprotection.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
(Assignee)

Comment 5

10 months ago
(In reply to Mike de Boer [:mikedeboer] from comment #3)
> Comment on attachment 8990684 [details]
> Bug 1472535 - Put the main menu tracking protection toggle behind a pref.
> 
> https://reviewboard.mozilla.org/r/255768/#review263362
> 
> I also hope that UX/ Product realize that hopping between ideas/ opinions
> and indecisiveness is not free, which this demonstrates. Sorry you have to
> spend time on this.

Thank you Mike and I agree 100%
Comment hidden (mozreview-request)

Comment 7

10 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9425042ce284
Put the main menu tracking protection toggle behind a pref. r=mikedeboer

Comment 8

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9425042ce284
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
(Assignee)

Comment 9

10 months ago
Peter, I haven't uplifted this yet to allow for the planning/design of the 63 UI and how that would impact things.

Bryan mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1468318#c4 that he thinks we'll disable the toggle in 62. Given the current state of things, do you agree we should uplift this and disable the main menu tracking protection toggle?
Flags: needinfo?(pdolanjski)
I can confirm the "privacy.trackingprotection.appMenuToggle.enabled" pref code was implemented on Nightly. I verified using Fx 63.0a1 (build ID: 20180723100101) on Windows 10 x64, Ubuntu 14.04 LTS and mac OS 10.13.5.
Status: RESOLVED → VERIFIED
Deferring this decision to Bryan/Ryan.
Flags: needinfo?(rfeeley)
Flags: needinfo?(pdolanjski)
Flags: needinfo?(bbell)
Flags: needinfo?(rfeeley)
You need to log in before you can comment on or make changes to this bug.