1472672 - [Static Analysis] Possible null-dereference in nsMaiInterfaceText.cpp

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P3)

Description

[Robert Bartlensky [:rbartlensky]]

infer reports the following error:
accessible/atk/nsMaiInterfaceText.cpp:467: error: NULL_DEREFERENCE
  pointer `textAcc` last assigned on line 465 could be null and is dereferenced at line 467, column 7.
  465.       HyperTextAccessible* textAcc = accWrap->AsHyperText();
  466.       return
  467. >       textAcc->IsDefunct() ? 0 : static_cast<gint>(textAcc->CharacterCount());
  468.     }
  469.

https://dxr.mozilla.org/mozilla-central/source/accessible/atk/nsMaiInterfaceText.cpp#467

textAcc can be null because `AsHyperText` can return null. I have checked to see if the code that calls `getCharacterCountCB` ever ensures that `aText` is a hyper text, but it is never the case. This means that the warning is indeed true.

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1472672: Add null check for textAcc.

Review commit: https://reviewboard.mozilla.org/r/254732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254732/

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8989748 [details]
Bug 1472672: Add null check for textAcc.

ok with me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c463161da7b4
Add null check for textAcc. r=davidb

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c463161da7b4