Closed
Bug 1472708
Opened 7 years ago
Closed 7 years ago
Integration Tests: sync Logins entry iOS-Desktop
Categories
(Firefox for iOS :: Build & Test, enhancement)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | + | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The aim of this test is to check that one history entry created in firefox-iOS appears correctly on desktop after sync.
The steps would be:
- firefox-iOS browse and save a login
- desktop sync and verify that the login is saved
This test has to be enabled only for this schema: Fennec_Enterprise_XCUITests_Integration
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → irios.mozilla
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8990752 -
Flags: review?(npark)
Attachment #8990752 -
Flags: review?(dave.hunt)
Updated•7 years ago
|
Attachment #8990752 -
Flags: review?(npark) → review+
Comment 2•7 years ago
|
||
Comment on attachment 8990752 [details] [review]
Pull Request
I'm currently having issues with my VPN connection, so I can't see the results from Jenkins. I'm surprised they passed as we have two methods of the same name.
Attachment #8990752 -
Flags: review?(dave.hunt) → review-
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Comment 4•7 years ago
|
||
Sorry, it was a copy/paste error, the test had the same name as the previous one. There was not a compilation error but only three, the first three tests passed.
I fixed the issue and tests are passing on Jenkins, see the log file attached.
Asking for r? again
Thanks!
Assignee | ||
Updated•7 years ago
|
Attachment #8990752 -
Flags: review?(dave.hunt)
Comment 5•7 years ago
|
||
Comment on attachment 8990752 [details] [review]
Pull Request
Looks good, thanks!
Attachment #8990752 -
Flags: review?(dave.hunt)
Attachment #8990752 -
Flags: review-
Attachment #8990752 -
Flags: review+
Assignee | ||
Comment 6•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/5d4a763a92c0188265e2da8469569a460babbce3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•