1472715 - about:telemetry reports wrong telemetry status in non-standard Nightly builds

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Christian Holler (:decoder)]

The ASan Reporter Nightly build is a Nightly build that has currently no telemetry enabled (mozconfig at browser/config/mozconfigs/linux64/nightly-asan-reporter has no MOZ_TELEMETRY_REPORTING set.

When I go to about:preferences, the checkbox saying "Allow Nightly to send technical and interaction data to Mozilla" is greyed out and disabled.

:mreid also confirmed that the browser is sending no telemetry data as expected.


However, in about:telemetry, it says:

"Telemetry is collecting pre-release data and upload is enabled."

This seems to be a display bug only (filing on request of :dexter).

Comment 1

[Jan-Erik Rediger [:janerik]]

This is indeed a display-issue only.
about:telemetry checks the `datareporting.healthreport.uploadEnabled` preference only[1], whereas the sending code checks that it is an official build (MOZILLA_OFFICIAL) with `MOZ_TELEMETRY_REPORTING` set [2].

If we want to fix this display bug, we would need to expose the `sendingEnabled` check as a Telemetry API (or directly call `TelemetrySend.sendingEnabled` in aboutTelemetry.js)

:gfritzsche, can you make a call which way we want to go?


[1]: https://searchfox.org/mozilla-central/rev/28daa2806c89684b3dfa4f0b551db1d099dda7c2/toolkit/content/aboutTelemetry.js#220
[2]: https://searchfox.org/mozilla-central/rev/28daa2806c89684b3dfa4f0b551db1d099dda7c2/toolkit/components/telemetry/TelemetrySend.jsm#1235-1250

Comment 2

[Georg Fritzsche [:gfritzsche]]

(In reply to Jan-Erik Rediger [:janerik] from comment #1)
> If we want to fix this display bug, we would need to expose the
> `sendingEnabled` check as a Telemetry API (or directly call
> `TelemetrySend.sendingEnabled` in aboutTelemetry.js)

Let's fix the display bug here. As about:telemetry is internal, using TelemetrySend.sendingEnabled or so sounds fine.

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1472715 - Show actual state of Telemetry upload on about:telemetry

Comment 4

[Phabricator Automation]

Comment on attachment 8990718 [details]
Bug 1472715 - Show actual state of Telemetry upload on about:telemetry

Georg Fritzsche [:gfritzsche] has approved the revision.

https://phabricator.services.mozilla.com/D2029

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d04bd6e1521f
Show actual state of Telemetry upload on about:telemetry r=gfritzsche

Comment 6

[Eliza Balazs [:ebalazs_]]

Backed out changeset d04bd6e1521f (bug 1472715) for ES lint failure in components/telemetry/TelemetrySend.jsm on a CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d04bd6e1521f4c03aa2df55c321dea24fac8b9d4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&selectedJob=187342304

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=187342304&repo=autoland&lineNumber=261

Backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a37eef374d201737232c041304435c5b96e0a046&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f39c4abc6ccd
Show actual state of Telemetry upload on about:telemetry r=gfritzsche

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f39c4abc6ccd