Closed Bug 1472792 Opened 2 years ago Closed Last year

Update actions spec to allow multiple actions with the same name, take the first one

Categories

(Taskcluster :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla63

People

(Reporter: dustin, Assigned: dustin)

References

Details

Attachments

(2 files)

We allow multiple entries in actions.json to have the same name, but require that their contexts make them apply to disjoint sets of tasks.  This is hard when you want a specific implementation for a few tasks, and a more general implementation for all other tasks.

We have an "order" for actions already.  So let's say that the first matching task, in order, is the one executed.
Once this is done, the two in-tree retriggers can both be named 'retrigger'.
Bug 1398277 needs a special retrigger action that applies only to decision tasks, with the default retrigger applying everywhere else.
We'll need a similar thing for treeherder, too.

/me smiles charmingly at Hassan..
Comment on attachment 8990450 [details]
Bug 1472792: give both retrigger actions the same name;

https://reviewboard.mozilla.org/r/255524/#review262338
Attachment #8990450 - Flags: review?(bstack) → review+
Huh, order isn't in the spec.  https://github.com/taskcluster/taskcluster-references/blob/master/schemas/action-schema-v1.yml

I think the in-tree stuff specifies an order for the array in actions.json.  So I'll re-configure..
https://github.com/taskcluster/taskcluster-docs/pull/270
https://github.com/taskcluster/taskcluster-tools/pull/543

updated to just use the existing order, rather than the (nonexistent) order field.
Attachment #8990450 - Flags: review+ → review?(bstack)
Comment on attachment 8990450 [details]
Bug 1472792: give both retrigger actions the same name;

https://reviewboard.mozilla.org/r/255524/#review262606
Attachment #8990450 - Flags: review?(bstack) → review+
Commits pushed to master at https://github.com/taskcluster/taskcluster-docs

https://github.com/taskcluster/taskcluster-docs/commit/5bfe3777581aab38c09eb2b807c6d3dc5c0d128e
Bug 1472792 - allow multiple actions with matching name

This takes advantage of the order in which actions are specified in the
array in `actions.json`.

https://github.com/taskcluster/taskcluster-docs/commit/642465a01c2a7ae9309631861f147a158b332cd8
Merge pull request #270 from djmitche/bug1472792

Bug 1472792 - allow multiple actions with matching name, choose by order
OK, I think this needs to get implemented in treeherder, then we can land the mozilla-central patch.  Hopefully that's a fairly small patch in TH.  Over to you, Hassan!
Assignee: dustin → helfi92
Thanks for your work Dustin. I will try to send a PR sometime this week.
Status: NEW → ASSIGNED
This is now implemented in Treeherder via https://github.com/mozilla/treeherder/commit/4438b788f0c208e97743e470da7cb6e811c2a0b3.
Assignee: helfi92 → nobody
Status: ASSIGNED → NEW
Awesome, thanks!
Assignee: nobody → dustin
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Whoops, I hadn't landed attachment 8990450 [details].  Landing it now with bug 1398277.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/4c20ba876af1
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Target Milestone: mozilla61 → mozilla63
You need to log in before you can comment on or make changes to this bug.