Need a test for bug 1466846 - "homepage" in chrome_settings_overrides not working in some cases

NEW
Assigned to

Status

enhancement
P2
normal
11 months ago
8 months ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Assignee

Description

11 months ago
bug 1466846 has a fix for a specific problem related to homepage in chrome_settings_overrides where if you disable and reenable, homepage is no longer taken over.

We should have a test for this.

I didn't do it as part of the bug because I was trying to get a quick fix in and honestly I wasn't sure how to write a test (the browser needs to restarted to show the bug).

Updated

11 months ago
Priority: -- → P2

Comment 1

11 months ago
(In reply to Mike Kaply [:mkaply] from comment #0)
> I didn't do it as part of the bug because I was trying to get a quick fix in
> and honestly I wasn't sure how to write a test (the browser needs to
> restarted to show the bug).

I didn't look all that closely at the patch, but if you just need to simulate how the extension is stopped and then re-started across a browser restart, you can do that from an xpcshell test with a simple `await promiseRestartManager();`  See something like test_ext_runtime_onInstalled_and_onStartup.js for an example.
Assignee

Updated

8 months ago
Assignee: nobody → mozilla
You need to log in before you can comment on or make changes to this bug.