1472815 - Need a test for bug 1466846 - "homepage" in chrome_settings_overrides not working in some cases

Status: RESOLVED WORKSFORME

(WebExtensions :: General, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

bug 1466846 has a fix for a specific problem related to homepage in chrome_settings_overrides where if you disable and reenable, homepage is no longer taken over.

We should have a test for this.

I didn't do it as part of the bug because I was trying to get a quick fix in and honestly I wasn't sure how to write a test (the browser needs to restarted to show the bug).

Comment 1

[Andrew Swan [:aswan]]

(In reply to Mike Kaply [:mkaply] from comment #0)
> I didn't do it as part of the bug because I was trying to get a quick fix in
> and honestly I wasn't sure how to write a test (the browser needs to
> restarted to show the bug).

I didn't look all that closely at the patch, but if you just need to simulate how the extension is stopped and then re-started across a browser restart, you can do that from an xpcshell test with a simple `await promiseRestartManager();`  See something like test_ext_runtime_onInstalled_and_onStartup.js for an example.

Comment 2

[Shane Caraveo (:mixedpuppy)]

doesn't look like it will get done

Comment 3

[Mike Kaply [:mkaply]]

Disabling and re-enabling an extension that overrides the homepage is covered by tests now (browser_ext_chrome_settings_overrides_home.js, test_ext_chrome_settings_overrides_update.js, test_ext_settings_overrides_defaults.js). Closing.