1472832 - Accessibility tests frequently hang

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

If I run all of the instrumented unit tests together, I pretty much always get timeouts in AccessibilityTest followed by the rest of the tests timing out. If I @Ignore AccessibilityTest, everything works as expected.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1472832 - Use notifyAll() in GeckoBackgroundThread

Without this we deadlock if more than one thread is waiting
in getHandler().

Review commit: https://reviewboard.mozilla.org/r/254342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254342/

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8989284 [details]
Bug 1472832 - Use notifyAll() in GeckoBackgroundThread

https://reviewboard.mozilla.org/r/254342/#review261276

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0675c7ddcc69
Use notifyAll() in GeckoBackgroundThread r=droeh

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0675c7ddcc69

Comment 6

[Intermittent Failures Robot]

7 failures in 622 pushes (0.011 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 7

Platform breakdown:
* android-em-4-3-armv7-api16: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1472832&startday=2018-07-02&endday=2018-07-08&tree=trunk

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8989284 [details]
Bug 1472832 - Use notifyAll() in GeckoBackgroundThread

Approval Request Comment
[Feature/Bug causing the regression]: GeckoView
[User impact if declined]: Accessibility in GeckoView can hang at startup
[Is this code covered by automated tests?]: Yes, gv-junit
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects GV
[String changes made/needed]: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8989284 [details]
Bug 1472832 - Use notifyAll() in GeckoBackgroundThread

Should only affect geckoview, let's uplift for beta 8.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7a488bdb5f3c