Closed
Bug 1472875
Opened 6 years ago
Closed 6 years ago
HTTP response text missing in devtools/network/headers panel
Categories
(DevTools :: Netmonitor, defect, P2)
Tracking
(firefox-esr60 unaffected, firefox62 wontfix, firefox63 fixed, firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox62 | --- | wontfix |
firefox63 | --- | fixed |
firefox64 | --- | fixed |
People
(Reporter: wallboy, Assigned: lucas.lunasouza, Mentored)
References
Details
(Keywords: good-first-bug, regression, Whiteboard: good-first-bug)
Attachments
(2 files)
27.16 KB,
image/png
|
Details | |
2.93 KB,
patch
|
Honza
:
review+
pascalc
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0 Build ID: 20180621125625 Steps to reproduce: I noticed in Firefox 61.0 that the HTTP response text is missing in the headers panel under Dev Tools/Network. Attached is an example showing the response text missing and where it usually is. I think it has to do with changes made in https://bugzilla.mozilla.org/show_bug.cgi?id=1435232 Actual results: HTTP Response text not present in headers panel beside the status code. Expected results: HTTP Response Text present beside status code: https://mdn.mozillademos.org/files/13266/nm-pieces.png
Updated•6 years ago
|
Has STR: --- → yes
Component: Untriaged → Netmonitor
Product: Firefox → DevTools
Comment 1•6 years ago
|
||
@Lucas: are you interested in fixing this regression? Honza
Flags: needinfo?(lucas.lunasouza)
Updated•6 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P2
Comment 2•6 years ago
|
||
Instructions for anyone interested: 1) This bug is caused by patch in bug 1435232 2) See this part of the patch: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&ignore=&bug=1435232&attachment=8964902 3) The input element has been removed. input({ className: "tabpanel-summary-value textbox-input devtools-monospace" + " status-text", readOnly: true, value: `${status} ${statusText}`, size: `${inputWidth}`, }), We need an element displaying the status-text back again. Honza
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] from comment #1) > @Lucas: are you interested in fixing this regression? > > Honza Sure, I can fix this.
Flags: needinfo?(lucas.lunasouza)
Comment 4•6 years ago
|
||
(In reply to Lucas Luna Souza from comment #3) > (In reply to Jan Honza Odvarko [:Honza] from comment #1) > > @Lucas: are you interested in fixing this regression? > > > > Honza > > Sure, I can fix this. Excellent, assigned to you, thanks! Honza
Assignee: nobody → lucas.lunasouza
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #8992188 -
Flags: review?(odvarko)
Comment 6•6 years ago
|
||
Comment on attachment 8992188 [details] [diff] [review] 1472875.patch Review of attachment 8992188 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch looks good to me! R+ assuming try is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=abd4d55e64d06557122f0749d60d4a92e16e7da0 Honza
Attachment #8992188 -
Flags: review?(odvarko) → review+
Updated•6 years ago
|
Keywords: checkin-needed
Comment 7•6 years ago
|
||
@Lucas: FYI, in order to make sure a patch is landed into the repository `checkin-needed` keyword must be set. Honza
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/315f887ca184 HTTP response text missing in devtools/network/headers panel r=Honza
Keywords: checkin-needed
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/315f887ca184
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment 10•6 years ago
|
||
Honza, is there a user impact which justifies Beta backport consideration here?
status-firefox62:
--- → wontfix
status-firefox63:
--- → affected
status-firefox-esr60:
--- → unaffected
Flags: needinfo?(odvarko)
Comment 11•6 years ago
|
||
Comment on attachment 8992188 [details] [diff] [review] 1472875.patch Approval Request Comment [Feature/Bug causing the regression]: bug 1435232 [User impact if declined]: Missing HTTP status text for HTTP request (in details panel) [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: n/a [Is the change risky?]: low risk [Why is the change risky/not risky?]: Just for developers, small patch [String changes made/needed]: n/a Honza
Flags: needinfo?(odvarko)
Attachment #8992188 -
Flags: approval-mozilla-beta?
Comment 12•6 years ago
|
||
Comment on attachment 8992188 [details] [diff] [review] 1472875.patch Small patch with tests fixing a regression affecting web developers, uplift approved for 63 beta 10, thanks.
Attachment #8992188 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 13•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/7b90b8e04295
You need to log in
before you can comment on or make changes to this bug.
Description
•