1472875 - HTTP response text missing in devtools/network/headers panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Adam]

Attachment: 0ZSl4gP.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180621125625

Steps to reproduce:

I noticed in Firefox 61.0 that the HTTP response text is missing in the headers panel under Dev Tools/Network.

Attached is an example showing the response text missing and where it usually is.

I think it has to do with changes made in https://bugzilla.mozilla.org/show_bug.cgi?id=1435232


Actual results:

HTTP Response text not present in headers panel beside the status code.


Expected results:

HTTP Response Text present beside status code: https://mdn.mozillademos.org/files/13266/nm-pieces.png

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Lucas: are you interested in fixing this regression?

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Instructions for anyone interested:

1) This bug is caused by patch in bug 1435232
2) See this part of the patch:
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&ignore=&bug=1435232&attachment=8964902

3) The input element has been removed.

input({ 
  className: "tabpanel-summary-value textbox-input devtools-monospace"  
    + " status-text", 
  readOnly: true, 
  value: `${status} ${statusText}`, 
  size: `${inputWidth}`,  
}),

We need an element displaying the status-text back again.

Honza

Comment 3

[Lucas Luna Souza]

(In reply to Jan Honza Odvarko [:Honza] from comment #1)
> @Lucas: are you interested in fixing this regression?
> 
> Honza

Sure, I can fix this.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Lucas Luna Souza from comment #3)
> (In reply to Jan Honza Odvarko [:Honza] from comment #1)
> > @Lucas: are you interested in fixing this regression?
> > 
> > Honza
> 
> Sure, I can fix this.

Excellent, assigned to you, thanks!

Honza

Comment 5

[Lucas Luna Souza]

Attachment: 1472875.patch

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8992188 [details] [diff] [review]
1472875.patch

Review of attachment 8992188 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch looks good to me!

R+ assuming try is green
https://treeherder.mozilla.org/#/jobs?repo=try&revision=abd4d55e64d06557122f0749d60d4a92e16e7da0

Honza

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Lucas: FYI, in order to make sure a patch is landed into the repository `checkin-needed` keyword must be set.

Honza

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/315f887ca184
HTTP response text missing in devtools/network/headers panel r=Honza

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/315f887ca184

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Honza, is there a user impact which justifies Beta backport consideration here?

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8992188 [details] [diff] [review]
1472875.patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1435232
[User impact if declined]: Missing HTTP status text for HTTP request (in details panel)
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: Just for developers, small patch
[String changes made/needed]: n/a

Honza

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 8992188 [details] [diff] [review]
1472875.patch

Small patch with tests fixing a regression affecting web developers, uplift approved for 63 beta 10, thanks.

Comment 13

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7b90b8e04295