Closed Bug 1472895 Opened 7 years ago Closed 7 years ago

Perma failure [tier2] toolkit/components/extensions/test/xpcshell/test_ext_cookies_samesite.js | xpcshell return code: 0

Categories

(Testing :: Code Coverage, defect, P5)

Product:
Testing
Component:
Code Coverage
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

Filed by: toros [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=186070999&repo=mozilla-central https://queue.taskcluster.net/v1/task/fb9-X4sIQk2S-gXDKcNiNQ/runs/0/artifacts/public/logs/live_backing.log [task 2018-07-02T22:58:24.507Z] INFO - TEST-START | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_cookies_samesite.js [task 2018-07-02T22:58:29.352Z] WARNING - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_cookies_samesite.js | xpcshell return code: 0 [task 2018-07-02T22:58:29.353Z] INFO - TEST-INFO took 4838ms [task 2018-07-02T22:58:29.353Z] INFO - >>>>>>> [task 2018-07-02T22:58:29.354Z] INFO - PID 13907 | [CodeCoverage] Setting handlers for process 13907. [task 2018-07-02T22:58:29.354Z] INFO - PID 13907 | [13907, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2682 [task 2018-07-02T22:58:29.356Z] INFO - PID 13907 | JavaScript strict warning: resource://testing-common/AddonTestUtils.jsm, line 304: ReferenceError: reference to undefined property "testScope" [task 2018-07-02T22:58:29.356Z] INFO - PID 13907 | JavaScript strict warning: resource://testing-common/AddonTestUtils.jsm, line 310: ReferenceError: reference to undefined property "testScope" [task 2018-07-02T22:58:29.356Z] INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "testScope"" {file: "resource://testing-common/AddonTestUtils.jsm" line: 304}]" [task 2018-07-02T22:58:29.356Z] INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "testScope"" {file: "resource://testing-common/AddonTestUtils.jsm" line: 310}]" [task 2018-07-02T22:58:29.356Z] INFO - PID 13907 | [CodeCoverage] Requested reset. [task 2018-07-02T22:58:29.356Z] INFO - PID 13907 | [CodeCoverage] Reset completed. [task 2018-07-02T22:58:29.357Z] INFO - (xpcshell/head.js) | test MAIN run_test pending (1) [task 2018-07-02T22:58:29.357Z] INFO - (xpcshell/head.js) | test run_next_test 0 pending (2) [task 2018-07-02T22:58:29.358Z] INFO - (xpcshell/head.js) | test MAIN run_test finished (2) [task 2018-07-02T22:58:29.358Z] INFO - running event loop
There are two "failing" tests in this test. The extension unit tests themselves appear to be correct, and the only odd-looking errors that I can spot is in the test coverage instrumentation code. > Error: [Exception... "Component returned failure code: 0x80520014 (NS_ERROR_FILE_DIR_NOT_EMPTY) [nsIFile.moveTo]" nsresult: "0x80520014 (NS_ERROR_FILE_DIR_NOT_EMPTY)" location: "JS frame :: resource://testing-common/PerTestCoverageUtils.jsm :: afterTest :: line 68" data: no] at resource://testing-common/PerTestCoverageUtils.jsm:31 The error in the log originates from this file: https://searchfox.org/mozilla-central/rev/b81d990de911d296ed67336f4ea20c4d97786a17/tools/code-coverage/PerTestCoverageUtils.jsm#68 The file has changed, but the logic still exists at: https://searchfox.org/mozilla-central/rev/448f792f9652d29daebdad21bf50b03405e40a45/tools/code-coverage/PerTestCoverageUtils.jsm#54,91 See the excerpts of the log below, for the two test failures: https://treeherder.mozilla.org/logviewer.html#?job_id=186095585&repo=mozilla-central&lineNumber=2038 [task 2018-07-03T01:14:32.979Z] WARNING - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_cookies_samesite.js | xpcshell return code: 0 [task 2018-07-03T01:14:32.980Z] INFO - TEST-INFO took 4805ms [task 2018-07-03T01:14:32.981Z] INFO - >>>>>>> [task 2018-07-03T01:14:32.981Z] INFO - PID 13905 | [CodeCoverage] Setting handlers for process 13905. ... [task 2018-07-03T01:14:32.982Z] INFO - PID 13905 | [CodeCoverage] Requested reset. [task 2018-07-03T01:14:32.982Z] INFO - PID 13905 | [CodeCoverage] Reset completed. ... (bunch of passing test results) [task 2018-07-03T01:14:33.009Z] INFO - TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_cookies_samesite.js | test_samesite_cookies - [test_samesite_cookies : 378] test result correct - "cookies" == "cookies" [task 2018-07-03T01:14:33.009Z] INFO - (xpcshell/head.js) | test run_next_test 2 pending (2) [task 2018-07-03T01:14:33.010Z] INFO - (xpcshell/head.js) | test test_samesite_cookies finished (2) [task 2018-07-03T01:14:33.011Z] INFO - (xpcshell/head.js) | test run_next_test 2 finished (1) [task 2018-07-03T01:14:33.011Z] INFO - exiting test ... [task 2018-07-03T01:14:33.012Z] INFO - PID 13905 | [CodeCoverage] Requested dump. [task 2018-07-03T01:14:33.013Z] INFO - PID 13905 | [CodeCoverage] Dump completed. [task 2018-07-03T01:14:33.014Z] INFO - Error: [Exception... "Component returned failure code: 0x80520014 (NS_ERROR_FILE_DIR_NOT_EMPTY) [nsIFile.moveTo]" nsresult: "0x80520014 (NS_ERROR_FILE_DIR_NOT_EMPTY)" location: "JS frame :: resource://testing-common/PerTestCoverageUtils.jsm :: afterTest :: line 68" data: no] at resource://testing-common/PerTestCoverageUtils.jsm:31 [task 2018-07-03T01:14:33.014Z] INFO - awaitPromise@resource://testing-common/PerTestCoverageUtils.jsm:31:11 [task 2018-07-03T01:14:33.015Z] INFO - afterTestSync@resource://testing-common/PerTestCoverageUtils.jsm:73:5 [task 2018-07-03T01:14:33.015Z] INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:537:5 ... [task 2018-07-03T01:14:33.030Z] INFO - <<<<<<< [task 2018-07-03T01:14:33.030Z] INFO - INFO | Result summary: [task 2018-07-03T01:14:33.031Z] INFO - INFO | Passed: 1 [task 2018-07-03T01:14:33.031Z] WARNING - INFO | Failed: 1 [task 2018-07-03T01:14:33.031Z] WARNING - One or more unittests failed. https://treeherder.mozilla.org/logviewer.html#?job_id=186095585&repo=mozilla-central&lineNumber=2450 [task 2018-07-03T01:16:17.067Z] WARNING - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_legacy_extension_embedding.js | xpcshell return code: 0 [task 2018-07-03T01:16:17.067Z] INFO - TEST-INFO took 3850ms [task 2018-07-03T01:16:17.067Z] INFO - >>>>>>> [task 2018-07-03T01:16:17.067Z] INFO - PID 28933 | [CodeCoverage] Setting handlers for process 28933. ... [task 2018-07-03T01:16:17.068Z] INFO - PID 28933 | [CodeCoverage] Requested reset. [task 2018-07-03T01:16:17.068Z] INFO - PID 28933 | [CodeCoverage] Reset completed. ... (bunch of passing test results) [task 2018-07-03T01:16:17.104Z] INFO - TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_legacy_extension_embedding.js | test_startup_error_blocking_validation_errors - [test_startup_error_blocking_validation_errors : 1] embedded extension startup rejected ... [task 2018-07-03T01:16:17.115Z] INFO - (xpcshell/head.js) | test run_next_test 5 pending (2) [task 2018-07-03T01:16:17.115Z] INFO - (xpcshell/head.js) | test test_startup_error_blocking_validation_errors finished (2) [task 2018-07-03T01:16:17.115Z] INFO - (xpcshell/head.js) | test run_next_test 5 finished (1) [task 2018-07-03T01:16:17.115Z] INFO - exiting test [task 2018-07-03T01:16:17.115Z] INFO - PID 28933 | [CodeCoverage] Requested dump. [task 2018-07-03T01:16:17.116Z] INFO - PID 28933 | [CodeCoverage] Dump completed. [task 2018-07-03T01:16:17.116Z] INFO - Error: [Exception... "Component returned failure code: 0x80520014 (NS_ERROR_FILE_DIR_NOT_EMPTY) [nsIFile.moveTo]" nsresult: "0x80520014 (NS_ERROR_FILE_DIR_NOT_EMPTY)" location: "JS frame :: resource://testing-common/PerTestCoverageUtils.jsm :: afterTest :: line 68" data: no] at resource://testing-common/PerTestCoverageUtils.jsm:31 [task 2018-07-03T01:16:17.116Z] INFO - awaitPromise@resource://testing-common/PerTestCoverageUtils.jsm:31:11 [task 2018-07-03T01:16:17.116Z] INFO - afterTestSync@resource://testing-common/PerTestCoverageUtils.jsm:73:5 [task 2018-07-03T01:16:17.116Z] INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:537:5 [task 2018-07-03T01:16:17.117Z] INFO - @-e:1:1 ... [task 2018-07-03T01:16:17.122Z] INFO - <<<<<<< [task 2018-07-03T01:16:17.122Z] INFO - INFO | Result summary: [task 2018-07-03T01:16:17.122Z] INFO - INFO | Passed: 1 [task 2018-07-03T01:16:17.122Z] WARNING - INFO | Failed: 1 [task 2018-07-03T01:16:17.123Z] WARNING - One or more unittests failed.
Component: General → Code Coverage
Product: WebExtensions → Testing
Marco, blame on tools/code-coverage/PerTestCoverageUtils.jsm points to your patch for bug 1470151. Please read my remarks in comment 2 and check if there is anything that you need to change in PerTestCoverageUtils.jsm to avoid unexpected test failures like these.
Flags: needinfo?(mcastelluccio)
See Also: → 1470151
Is this still happening? I think it should have been fixed with bug 1472688.
Flags: needinfo?(mcastelluccio)
Depends on: 1472688
The bug has not occurred any more since then: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2018-03-18&endday=2018-07-16&tree=trunk&bug=1472895 If you believe that my analysis is correct and that your patch has fixed that issue, please mark the bug as resolved.
(In reply to Rob Wu [:robwu] from comment #6) > The bug has not occurred any more since then: > https://treeherder.mozilla.org/intermittent-failures.html#/ > bugdetails?startday=2018-03-18&endday=2018-07-16&tree=trunk&bug=1472895 > > If you believe that my analysis is correct and that your patch has fixed > that issue, please mark the bug as resolved. Yes, it was correct! Thanks.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.