Implement the even smarter interpolation for transform list

RESOLVED FIXED in Firefox 64

Status

()

P3
normal
RESOLVED FIXED
8 months ago
4 months ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

(URL)

Attachments

(4 attachments)

The CSSWG just resolved to do the smarter interpolation of transform lists where we interpolate the common prefix of mismatched lists and use matrix interpolation for the remainder (which I think is what Hiro originally implemented in bug 1464647).

See https://github.com/w3c/csswg-drafts/issues/927#issuecomment-402009799
I made an attempt at specifying this behavior the group seemed to resolve on:

  https://github.com/w3c/csswg-drafts/pull/3215
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Created attachment 9018471 [details]
Bug 1472917 - Add tests for transform list interpolation; r?hiro
Created attachment 9018472 [details]
Bug 1472917 - Fix a couple of typos in transform interpolation tests; r?hiro

Depends on D9182
Created attachment 9018473 [details]
Bug 1472917 - Update test_transitions_per_property.html so it continues to work

with the new interpolation rules; r?hiro

The updated tests are intended to cover percent translation when using matrix
decomposition but after introducing the new interpolation rules the initial
rotate() functions will match so the result will differ. This patch updates the
test values so that the result will not change even after introducing the new
interpolation rules.

Depends on D9183
Created attachment 9018474 [details]
Bug 1472917 - Implement the even more forgiving interpolation rules for transform lists; r?hiro

As discussed in:

  https://github.com/w3c/csswg-drafts/issues/927

with tentative spec text:

  https://github.com/w3c/csswg-drafts/pull/3215

Depends on D9184

Comment 8

4 months ago
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bad2ba4312cc
Add tests for transform list interpolation; r=hiro
https://hg.mozilla.org/integration/autoland/rev/cd10f03f6640
Fix a couple of typos in transform interpolation tests; r=hiro
https://hg.mozilla.org/integration/autoland/rev/e7aff1bbcd20
Update test_transitions_per_property.html so it continues to work r=hiro
https://hg.mozilla.org/integration/autoland/rev/660b4ee6c913
Implement the even more forgiving interpolation rules for transform lists; r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13610 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bad2ba4312cc
https://hg.mozilla.org/mozilla-central/rev/cd10f03f6640
https://hg.mozilla.org/mozilla-central/rev/e7aff1bbcd20
https://hg.mozilla.org/mozilla-central/rev/660b4ee6c913
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.