1472917 - Implement the even smarter interpolation for transform list

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Brian Birtles (:birtles)]

The CSSWG just resolved to do the smarter interpolation of transform lists where we interpolate the common prefix of mismatched lists and use matrix interpolation for the remainder (which I think is what Hiro originally implemented in bug 1464647).

See https://github.com/w3c/csswg-drafts/issues/927#issuecomment-402009799

Comment 1

[Brian Birtles (:birtles)]

I made an attempt at specifying this behavior the group seemed to resolve on:

  https://github.com/w3c/csswg-drafts/pull/3215

Comment 2

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a82d59a8e63b90c99bf3ac4fe64c496a0f4775

Comment 3

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a59c296d75552e90d334219908e53bca706c53e8

Comment 4

[Brian Birtles (:birtles)]

Attachment: Bug 1472917 - Add tests for transform list interpolation; r?hiro

Comment 5

[Brian Birtles (:birtles)]

Attachment: Bug 1472917 - Fix a couple of typos in transform interpolation tests; r?hiro

Depends on D9182

Comment 6

[Brian Birtles (:birtles)]

Attachment: Bug 1472917 - Update test_transitions_per_property.html so it continues to work

with the new interpolation rules; r?hiro

The updated tests are intended to cover percent translation when using matrix
decomposition but after introducing the new interpolation rules the initial
rotate() functions will match so the result will differ. This patch updates the
test values so that the result will not change even after introducing the new
interpolation rules.

Depends on D9183

Comment 7

[Brian Birtles (:birtles)]

Attachment: Bug 1472917 - Implement the even more forgiving interpolation rules for transform lists; r?hiro

As discussed in:

  https://github.com/w3c/csswg-drafts/issues/927

with tentative spec text:

  https://github.com/w3c/csswg-drafts/pull/3215

Depends on D9184

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bad2ba4312cc
Add tests for transform list interpolation; r=hiro
https://hg.mozilla.org/integration/autoland/rev/cd10f03f6640
Fix a couple of typos in transform interpolation tests; r=hiro
https://hg.mozilla.org/integration/autoland/rev/e7aff1bbcd20
Update test_transitions_per_property.html so it continues to work r=hiro
https://hg.mozilla.org/integration/autoland/rev/660b4ee6c913
Implement the even more forgiving interpolation rules for transform lists; r=hiro

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13610 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bad2ba4312cc
https://hg.mozilla.org/mozilla-central/rev/cd10f03f6640
https://hg.mozilla.org/mozilla-central/rev/e7aff1bbcd20
https://hg.mozilla.org/mozilla-central/rev/660b4ee6c913

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged