Closed Bug 1472979 Opened Last year Closed Last year

add web-tooling-benchmark as a jsshell-bench test

Categories

(Testing :: General, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jmaher, Assigned: igoldan)

References

Details

Attachments

(1 file)

web-tooling-benchmark is currently run on AWFY, primarily for v8, not for firefox.

I would like to get this added for jsshell-bench right now so we have it running.  If you look at what is running in awfy:
https://github.com/mozilla/arewefastyet/tree/master/benchmarks/web-tooling-benchmark

there is a 25MB cli.js file, we should consider making this a fetch task or some type of artifact.

The source and docs are here:
https://github.com/v8/web-tooling-benchmark

here is the reference to running/parsing the data:
https://github.com/mozilla/arewefastyet/blob/71255695f7927453778135b8b190b09b75c062fb/slave/benchmarks_shell.py#L304

I think it is just as simple as |jsshell cli.js|, then parsing the results.
Priority: -- → P3
Depends on: 1468812
Assignee: nobody → rwood
Status: NEW → ASSIGNED
See Also: → 1465336
Making this still up for grabs as I am busy with raptor-android atm
Assignee: rwood → nobody
Status: ASSIGNED → NEW
Assignee: nobody → igoldan
Add Web Tooling Benchmark & (WIP) setup fetch task
Comment on attachment 8996982 [details]
Bug 1472979 - Add Web Tooling Benchmark as a jsshell-bench test

I was able to make this run locally. Now I've started adding in the fetch task. I used an approach similar to :ahal's [1]. At the moment, it errors out on Try.

Still, this is to know whether I'm on the right track or not.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1472800#c21
Attachment #8996982 - Flags: feedback?(rwood)
Comment on attachment 8996982 [details]
Bug 1472979 - Add Web Tooling Benchmark as a jsshell-bench test

Please ask someone for feedback who has experience with the jsshell framework. I haven't looked at it (yet).
Attachment #8996982 - Flags: feedback?(rwood)
Attachment #8996982 - Flags: review?(jmaher)
Comment on attachment 8996982 [details]
Bug 1472979 - Add Web Tooling Benchmark as a jsshell-bench test

Joel Maher ( :jmaher ) (UTC+2) has approved the revision.
Attachment #8996982 - Flags: review+
Attachment #8996982 - Flags: review?(jmaher) → review+
:igoldan, lando was not able to rebase the commits, please pick this up first thing when you get back so we can get this up and running.
Flags: needinfo?(igoldan)
Pushed by igoldan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/957f7aa848b1
Add Web Tooling Benchmark as a jsshell-bench test r=jmaher
(In reply to Joel Maher ( :jmaher ) (UTC+2) from comment #8)
> :igoldan, lando was not able to rebase the commits, please pick this up
> first thing when you get back so we can get this up and running.

I've rebased & pushed again.
Flags: needinfo?(igoldan)
https://hg.mozilla.org/mozilla-central/rev/957f7aa848b1
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.