Closed
Bug 1472979
Opened 6 years ago
Closed 6 years ago
add web-tooling-benchmark as a jsshell-bench test
Categories
(Testing :: General, enhancement, P3)
Testing
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jmaher, Assigned: igoldan)
References
Details
Attachments
(1 file)
web-tooling-benchmark is currently run on AWFY, primarily for v8, not for firefox.
I would like to get this added for jsshell-bench right now so we have it running. If you look at what is running in awfy:
https://github.com/mozilla/arewefastyet/tree/master/benchmarks/web-tooling-benchmark
there is a 25MB cli.js file, we should consider making this a fetch task or some type of artifact.
The source and docs are here:
https://github.com/v8/web-tooling-benchmark
here is the reference to running/parsing the data:
https://github.com/mozilla/arewefastyet/blob/71255695f7927453778135b8b190b09b75c062fb/slave/benchmarks_shell.py#L304
I think it is just as simple as |jsshell cli.js|, then parsing the results.
Updated•6 years ago
|
Priority: -- → P3
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Making this still up for grabs as I am busy with raptor-android atm
Assignee: rwood → nobody
Status: ASSIGNED → NEW
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → igoldan
Assignee | ||
Comment 2•6 years ago
|
||
Add Web Tooling Benchmark & (WIP) setup fetch task
Assignee | ||
Comment 3•6 years ago
|
||
Comment on attachment 8996982 [details]
Bug 1472979 - Add Web Tooling Benchmark as a jsshell-bench test
I was able to make this run locally. Now I've started adding in the fetch task. I used an approach similar to :ahal's [1]. At the moment, it errors out on Try.
Still, this is to know whether I'm on the right track or not.
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1472800#c21
Attachment #8996982 -
Flags: feedback?(rwood)
Assignee | ||
Comment 4•6 years ago
|
||
This is the failing push to Try: https://treeherder.mozilla.org/#/jobs?repo=try&author=igoldan@mozilla.com&fromchange=bb0735e080db62dd44703e312fb7f828d003ace1
Comment 5•6 years ago
|
||
Comment on attachment 8996982 [details]
Bug 1472979 - Add Web Tooling Benchmark as a jsshell-bench test
Please ask someone for feedback who has experience with the jsshell framework. I haven't looked at it (yet).
Attachment #8996982 -
Flags: feedback?(rwood)
Assignee | ||
Updated•6 years ago
|
Attachment #8996982 -
Flags: review?(jmaher)
Assignee | ||
Comment 6•6 years ago
|
||
I did a Try push here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a282b411874ff7c28558bf5ed254ec59d4cec8f1&filter-tier=1&filter-tier=2&filter-tier=3
All jobs are green, except the yaml linting; I fixed that also here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=017f382599a976042424e1e591900f76e9c27f51
The last revision on Phabricator now has all jobs green.
Reporter | ||
Comment 7•6 years ago
|
||
Comment on attachment 8996982 [details]
Bug 1472979 - Add Web Tooling Benchmark as a jsshell-bench test
Joel Maher ( :jmaher ) (UTC+2) has approved the revision.
Attachment #8996982 -
Flags: review+
Reporter | ||
Updated•6 years ago
|
Attachment #8996982 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 8•6 years ago
|
||
:igoldan, lando was not able to rebase the commits, please pick this up first thing when you get back so we can get this up and running.
Flags: needinfo?(igoldan)
Pushed by igoldan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/957f7aa848b1
Add Web Tooling Benchmark as a jsshell-bench test r=jmaher
Assignee | ||
Comment 10•6 years ago
|
||
(In reply to Joel Maher ( :jmaher ) (UTC+2) from comment #8)
> :igoldan, lando was not able to rebase the commits, please pick this up
> first thing when you get back so we can get this up and running.
I've rebased & pushed again.
Flags: needinfo?(igoldan)
Comment 11•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•