Closed Bug 1473024 Opened 6 years ago Closed 6 years ago

CSP should throw EvalError when blocking eval()

Categories

(Core :: DOM: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 2 obsolete files)

      No description provided.
Attached patch csp_eval.patch (obsolete) — Splinter Review
Attachment #8989432 - Flags: review?(ckerschb)
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Attached patch csp_eval.patch (obsolete) — Splinter Review
WPT fixed
Attachment #8989432 - Attachment is obsolete: true
Attachment #8989432 - Flags: review?(ckerschb)
Attachment #8989482 - Flags: review?(ckerschb)
Attached patch csp_eval.patchSplinter Review
The last WPT has been marked. Green on try.
Attachment #8989482 - Attachment is obsolete: true
Attachment #8989482 - Flags: review?(ckerschb)
Attachment #8989662 - Flags: review?(ckerschb)
Comment on attachment 8989662 [details] [diff] [review]
csp_eval.patch

Review of attachment 8989662 [details] [diff] [review]:
-----------------------------------------------------------------

that looks good - thanks, r=me
Attachment #8989662 - Flags: review?(ckerschb) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78d32cf0c528
CSP should throw EvalError when blocking eval(), r=ckerschb
https://hg.mozilla.org/mozilla-central/rev/78d32cf0c528
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: