1473061 - Provide an option to show flex basis in the flexbox highlighter

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1473061 - Provide an option to show flex basis in the flexbox highlighter.

Review commit: https://reviewboard.mozilla.org/r/254518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254518/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8989465 [details]
Bug 1473061 - Provide an option to show flex basis in the flexbox highlighter.

https://reviewboard.mozilla.org/r/254518/#review261340


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/server/actors/highlighters/flexbox.js:542
(Diff revision 1)
>  
>    /**
>     * Renders the flex basis for a given flex item.
>     */
>    renderFlexItemBasis(flexItem, left, top, right, bottom, boundsWidth) {
> -    if (!this.computedStyle) {
> +    if (!this.options.showFlexBasis || this.!this.computedStyle) {

Error: Parsing error: unexpected token ! [eslint]

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8989465 [details]
Bug 1473061 - Provide an option to show flex basis in the flexbox highlighter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254518/diff/1-2/

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8989465 [details]
Bug 1473061 - Provide an option to show flex basis in the flexbox highlighter.

https://reviewboard.mozilla.org/r/254518/#review261536

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5cf5667c147
Provide an option to show flex basis in the flexbox highlighter. r=pbro

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a5cf5667c147