1473103 - Regression test for mozglue DLL blocklist

Status: RESOLVED FIXED

(Core :: mozglue, defect, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We might have been able to catch bug 1472030 before it reached Beta if we had a proper regression test for the DLL blocklist.

I noticed that our existing blocklist already contains entries for "mozdllblockingtest.dll" and "mozdllblockingtest_versioned.dll" but a cursory code search doesn't show those libraries actually existing anywhere!

In addition to testing some of the essential functionality, I'd also like us to validate that the entire array of blocklist entries is being generated correctly. In particular, I'd like to ensure that if we compare the ArrayLength(gWindowsDllBlocklist) == (the length of the blocklist if we scan it in a while loop searching for the terminating null entry).

Carl, since you've already been dabbling in that area with gtests et al, I thought I'd send this your way.

Comment 1

[Carl Corcoran [:ccorcoran]]

Attachment: Bug 1473103: Add unit tests for DLL blocklist integrity; r?aklotz

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8992890 [details]
Bug 1473103: Add unit tests for DLL blocklist integrity; r?aklotz

Aaron Klotz [:aklotz] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9207b4b0e5db
Add unit tests for DLL blocklist integrity; r=aklotz

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9207b4b0e5db

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something we might want to consider for Beta backport or is manual QA sufficient?

Comment 6

[Carl Corcoran [:ccorcoran]]

I don't see any need to backport this.