1473158 - Write a basic test for the selectBookmark sub-dialog in preferences.

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Mark Banner (:standard8)]

Currently we have no tests for the selectBookmark.xul sub-dialog in preferences.

A couple of times now we've almost broken this, so I think it is definitely time we have a test at least covering a basic select a bookmark and check that the homepage is set as expected.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1473158 - Add a basic test for the selectBookmark sub-dialog in preferences.

MozReview-Commit-ID: KCCKHRvOCme

Comment 2

[:Gijs (he/him)]

Did you mean to ask someone for review?

(Tentatively marking P1 given it has an assignee and all that)

Comment 3

[Mark Banner (:standard8)]

(In reply to :Gijs (he/him) from comment #2)
> Did you mean to ask someone for review?
> 
> (Tentatively marking P1 given it has an assignee and all that)

Phabricator doesn't post review requests in bugzilla (only review granted). Though I've just realised Jared is out until next week... any volunteers?

Comment 4

[Phabricator Automation]

Comment on attachment 8989563 [details]
Bug 1473158 - Add a basic test for the selectBookmark sub-dialog in preferences.

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

https://phabricator.services.mozilla.com/D1932

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccdb64ade35f
Add a basic test for the selectBookmark sub-dialog in preferences. r=jaws

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ccdb64ade35f