Closed Bug 1473187 Opened Last year Closed Last year
Add ability to select multiple tabs using both Shift + Ctrl/Cmd at the same time
59 bytes, text/x-review-board-request
This should work like mutli-select using shift only except that it doesn't remove tabs from the selection. For example let's consider the following scenario with five tabs: 1. A,B,C,D,E 2. switch to tab C (Active tab) 3. hold Shift key only and select tab E 4. A,B are not selected and C-E selected 5. Hold Shift+Ctrl/Cmd and select tab A 6. A-E are selected. Now if only Shift key was held in 5: a. the selected tabs would be A-C b. and D,E would be removed from the selection.
Comment on attachment 8990531 [details] Bug 1473187 - Add support for using both Shift and Ctrl/Cmd at the same time to select tabs. https://reviewboard.mozilla.org/r/255554/#review262542 ::: browser/base/content/test/tabs/browser_multiselect_tabs_using_Shift_and_Ctrl.js:68 (Diff revision 1) > + ok(tab1.multiselected, "Tab1 is multi-selected"); > + ok(!tab2.multiselected, "Tab2 is not multi-selected "); > + ok(tab3.multiselected, "Tab3 is multi-selected"); > + ok(!tab4.multiselected, "Tab4 is not multi-selected"); > + ok(!tab5.multiselected, "Tab5 is not multi-selected"); > + is(gBrowser.multiSelectedTabsCount, 2, "Three tabs are multi-selected"); Nit: "Two tabs..."
Attachment #8990531 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/0a40095e5329 Add support for using both Shift and Ctrl/Cmd at the same time to select tabs. r=Gijs
Verified fixed in latest nightly 65.0a1(2018-11-08) and latest Beta 64.0b8 on Windows 10x64, macOS 10.13 and Ubuntu 16.04x64.
You need to log in before you can comment on or make changes to this bug.