Closed Bug 1473201 Opened 4 years ago Closed 4 years ago

Color graph of keyframes looks a bit different color from actual animated color

Categories

(DevTools :: Inspector: Animations, defect, P2)

defect

Tracking

(firefox62 fixed, firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached file color.html
Steps to reproduce:
1. Open attached html which animates background-color.
2. Open animation inspector

Expected result:
The color of keyframe's graph should be same to the actual animated color.

Actual result:
The color of keyframe's graph looks different from the actual animated color.

The reason was that we are setting `fill-opacity: 0.5` to all keyframe's graph[1].
I guess, this will fix if we set 1.0 to fill-opacity for the color type graph.

[1] https://searchfox.org/mozilla-central/source/devtools/client/themes/animation.css#510
Comment on attachment 8989624 [details]
Bug 1473201: Change fill-opacity for color path to show actual color.

https://reviewboard.mozilla.org/r/254648/#review261616

Looks good Daisuke, thanks for adding the STRs!
Attachment #8989624 - Flags: review?(jdescottes) → review+
Thank you for the reviewing, Julian!
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47876d4166f3
Change fill-opacity for color path to show actual color. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/47876d4166f3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Comment on attachment 8989624 [details]
Bug 1473201: Change fill-opacity for color path to show actual color.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1399830
[User impact if declined]: May make user to misunderstand color transitions.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: It has baked on Nightly for 1 day.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: Low
[Why is the change risky/not risky?]: This change is the style only.
[String changes made/needed]: No
Attachment #8989624 - Flags: approval-mozilla-beta?
Comment on attachment 8989624 [details]
Bug 1473201: Change fill-opacity for color path to show actual color.

CSS fix for a new feature, let's uplift.
Attachment #8989624 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Based on comment 6, marking as qe-.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.