1473201 - Color graph of keyframes looks a bit different color from actual animated color

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect, P2)

Description

[Daisuke Akatsuka (:daisuke)]

Attachment: color.html

Steps to reproduce:
1. Open attached html which animates background-color.
2. Open animation inspector

Expected result:
The color of keyframe's graph should be same to the actual animated color.

Actual result:
The color of keyframe's graph looks different from the actual animated color.

The reason was that we are setting `fill-opacity: 0.5` to all keyframe's graph[1].
I guess, this will fix if we set 1.0 to fill-opacity for the color type graph.

[1] https://searchfox.org/mozilla-central/source/devtools/client/themes/animation.css#510

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1473201: Change fill-opacity for color path to show actual color.

Review commit: https://reviewboard.mozilla.org/r/254648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254648/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8989624 [details]
Bug 1473201: Change fill-opacity for color path to show actual color.

https://reviewboard.mozilla.org/r/254648/#review261616

Looks good Daisuke, thanks for adding the STRs!

Comment 3

[Daisuke Akatsuka (:daisuke)]

Thank you for the reviewing, Julian!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47876d4166f3
Change fill-opacity for color path to show actual color. r=jdescottes

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/47876d4166f3

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8989624 [details]
Bug 1473201: Change fill-opacity for color path to show actual color.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1399830
[User impact if declined]: May make user to misunderstand color transitions.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: It has baked on Nightly for 1 day.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: Low
[Why is the change risky/not risky?]: This change is the style only.
[String changes made/needed]: No

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8989624 [details]
Bug 1473201: Change fill-opacity for color path to show actual color.

CSS fix for a new feature, let's uplift.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ecb1c1bf6f48

Comment 9

[Catalin Sasca, Desktop QA [:csasca]]

Based on comment 6, marking as qe-.