1473228 - Add Intl.RelativeTimeFormat.prototype[@@toStringTag]

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[André Bargull [:anba]]

Add Intl.RelativeTimeFormat.prototype[@@toStringTag], but probably wait until <https://github.com/tc39/proposal-intl-relative-time/issues/72> was resolved.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Add @@toStringTag in Intl.RelativeTimeFormat.

Comment 2

[Ashley Hauck [:khyperia]]

Note that the value of it actually is "Intl.RelativeTimeFormat", unlike what seems like other Intl.* objects, which are "Object".

https://tc39.github.io/proposal-intl-relative-time/#sec-Intl.RelativeTimeFormat.prototype-toStringTag

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 9002846 [details] [diff] [review]
Add @@toStringTag in Intl.RelativeTimeFormat.

Review of attachment 9002846 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/non262/Intl/RelativeTimeFormat/relativetimeformat.js
@@ +9,5 @@
>  
>  addIntlExtras(Intl);
>  
>  rtf = new Intl.RelativeTimeFormat("en-us");
> +assertEq(rtf[Symbol.toStringTag], "Intl.RelativeTimeFormat");

Instead, delete these lines from js/src/tests/jstests.list:

# https://bugzilla.mozilla.org/show_bug.cgi?id=1473228
skip script test262/intl402/RelativeTimeFormat/prototype/toStringTag/toString.js
skip script test262/intl402/RelativeTimeFormat/prototype/toStringTag/toStringTag.js

Comment 4

[Ashley Hauck [:khyperia]]

Attachment: Add @@toStringTag in Intl.RelativeTimeFormat.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e8bad5cea6
Add @@toStringTag in Intl.RelativeTimeFormat. r=jorendorff

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c1e8bad5cea6