Closed Bug 1473228 Opened 2 years ago Closed 2 years ago

Add Intl.RelativeTimeFormat.prototype[@@toStringTag]

Categories

(Core :: JavaScript: Internationalization API, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: anba, Assigned: khyperia)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Add Intl.RelativeTimeFormat.prototype[@@toStringTag], but probably wait until <https://github.com/tc39/proposal-intl-relative-time/issues/72> was resolved.
Assignee: nobody → khyperia
Status: NEW → ASSIGNED
Attachment #9002846 - Flags: review?(jwalden+bmo)
Note that the value of it actually is "Intl.RelativeTimeFormat", unlike what seems like other Intl.* objects, which are "Object".

https://tc39.github.io/proposal-intl-relative-time/#sec-Intl.RelativeTimeFormat.prototype-toStringTag
Comment on attachment 9002846 [details] [diff] [review]
Add @@toStringTag in Intl.RelativeTimeFormat.

Review of attachment 9002846 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/non262/Intl/RelativeTimeFormat/relativetimeformat.js
@@ +9,5 @@
>  
>  addIntlExtras(Intl);
>  
>  rtf = new Intl.RelativeTimeFormat("en-us");
> +assertEq(rtf[Symbol.toStringTag], "Intl.RelativeTimeFormat");

Instead, delete these lines from js/src/tests/jstests.list:

# https://bugzilla.mozilla.org/show_bug.cgi?id=1473228
skip script test262/intl402/RelativeTimeFormat/prototype/toStringTag/toString.js
skip script test262/intl402/RelativeTimeFormat/prototype/toStringTag/toStringTag.js
Attachment #9002846 - Flags: review?(jwalden+bmo) → review+
Attachment #9002846 - Attachment is obsolete: true
Attachment #9002912 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e8bad5cea6
Add @@toStringTag in Intl.RelativeTimeFormat. r=jorendorff
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c1e8bad5cea6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.