1473230 - Allow plural units in Intl.RelativeTimeFormat

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[André Bargull [:anba]]

Plural unit values should be allowed for Intl.RelativeTimeFormat per <https://github.com/tc39/proposal-intl-relative-time/commit/3b98baba6c120f2199c3227655c4e4c673c471a9>.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Allow plural units in Intl.RelativeTimeFormat.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 9002872 [details] [diff] [review]
Allow plural units in Intl.RelativeTimeFormat.

Review of attachment 9002872 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review. r=me. Please upload an updated patch with the requested change below and `r=jorendorff` at the end of the first line of the commit message, then set the checkin-needed keyword on this bug.

::: js/src/tests/non262/Intl/RelativeTimeFormat/format.js
@@ +89,5 @@
>    assertEq(rtf.format(1, "year"), "next year");
>  }
>  
> +{
> +  // Plural specifier

Instead, delete these lines from jstests.list:

# https://bugzilla.mozilla.org/show_bug.cgi?id=1473230
skip script test262/intl402/RelativeTimeFormat/prototype/format/unit-plural.js

Comment 3

[Jason Orendorff [:jorendorff]]

You'll have to set the "review" flag on your new patch to r+.

(As a matter of policy, you of course can't review your own patch; but as a matter of practicality, the system doesn't enforce this, and it's 100% correct procedure to mark a slightly modified patch r+ yourself, in cases like this, rather than pester a reviewer to stamp the same patch a second time.)

Comment 4

[Ashley Hauck [:khyperia]]

Debugged through the "quarter" failure until the first time "UDAT_REL_UNIT_QUARTER" is unhandled. That location is here [0].

Talked with Jason offline, and the decision is that we'll land this patch as-is until the quarter situation is figured out in ICU.

[0] https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/intl/icu/source/i18n/reldatefmt.cpp#840-851

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e68b064f46b9
Allow plural units in Intl.RelativeTimeFormat. r=jorendorff

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e68b064f46b9

Comment 7

[Florian Scholz (Open Web Docs)]

Plural forms are mentioned in the syntax section of the docs https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RelativeTimeFormat/format#Syntax