Closed
Bug 1473231
Opened 7 years ago
Closed 7 years ago
Update test262 (Jul 04 2018 edition)
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(3 files)
4.45 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
1.54 MB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
4.37 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Update the importer to handle new "flag" and "feature" options and remove the temporary workaround for the Atomics tests (the upstream issue has been fixed).
Experimental Intl APIs are not enabled by default, even not in Nightly, instead the |addIntlExtras| shell function needs to be called to add the experimental APIs to the Intl object. Add a helper file and include it using the importer for Intl.RelativeTimeFormat tests. (The same approach was used when Intl.PluralRules wasn't enabled by default.)
Attachment #8989811 -
Flags: review?(sphink)
Assignee | ||
Comment 2•7 years ago
|
||
The actual test262 update.
Attachment #8989813 -
Flags: review?(sphink)
Assignee | ||
Comment 3•7 years ago
|
||
Updates the exclusion file after the test262 update.
I've re-enabled the currently disabled Atomics tests because <https://github.com/tc39/test262/pull/1617> should have fixed the observed intermittent failures.
Attachment #8989815 -
Flags: review?(sphink)
Comment 4•7 years ago
|
||
Comment on attachment 8989811 [details] [diff] [review]
bug1473231-part1-update-importer.patch
Review of attachment 8989811 [details] [diff] [review]:
-----------------------------------------------------------------
You're awesome. Thank you.
Attachment #8989811 -
Flags: review?(sphink) → review+
Updated•7 years ago
|
Attachment #8989813 -
Flags: review?(sphink) → review+
Updated•7 years ago
|
Attachment #8989815 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b406e710db5a1f454b3adc6c80f86ebe3a404026
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f898765faf5
Part 1: Update test262 importer to handle new feature flags. r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/af8711af6fef
Part 2: Update test262 - Jul 04 2018 edition. r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf8b3521ee57
Part 3: Update test262 exclusions. r=sfink
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3f898765faf5
https://hg.mozilla.org/mozilla-central/rev/af8711af6fef
https://hg.mozilla.org/mozilla-central/rev/cf8b3521ee57
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•