1473247 - Making the firstPartyDomain honors IP addresses

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P1)

Description

[Tim Huang[:timhuang]]

The firstPartyDomain won't be set if the first party is an IP address when the first party isolation is enabled. It is because of the TLD service doesn't treat IP addresses as a valid base domain. We should fix this since an IP address should be considered as a valid first party domain.

Comment 1

[Simon Mainey]

Are other origin attributes honored with IP addresses? eg containers, PB mode?

Comment 2

[Tim Huang[:timhuang]]

Yes, they are. The firstPartyDomain is the only one exception right now.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1473247 - Part 1: Fixing the issue that the IP addresses won't be set for first party domains. r=baku, arthuredelstein

Right now, the firstPartyDomain won't be set when using IP addresses as
first party domains. It is because of that the TLD service won't accept
IP addresses as valid hosts. The patch fixes this problem by detecting
that if the host is a IP address. If it is, we will still set the
firstPartyDoamin with the IP address.

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1473247 - Part 2: Add a test case for making sure that IP addresses can work properly for the firstPartyDomain. r=baku, arthuredelstein

Comment 5

[Phabricator Automation]

Comment on attachment 8990106 [details]
Bug 1473247 - Part 1: Fixing the issue that the IP addresses won't be set for first party domains. r=baku, arthuredelstein

Andrea Marchesini [:baku] has approved the revision.

https://phabricator.services.mozilla.com/D1977

Comment 6

[Phabricator Automation]

Comment on attachment 8990107 [details]
Bug 1473247 - Part 2: Add a test case for making sure that IP addresses can work properly for the firstPartyDomain. r=baku, arthuredelstein

Andrea Marchesini [:baku] has approved the revision.

https://phabricator.services.mozilla.com/D1978

Comment 7

[Tim Huang[:timhuang]]

Hi Arthur,

Would you be able to review this? Or do you encounter any problem with registering a Phabricator account? If so, please let me know, I can find someone to help.

Comment 8

[Phabricator Automation]

Comment on attachment 8990106 [details]
Bug 1473247 - Part 1: Fixing the issue that the IP addresses won't be set for first party domains. r=baku, arthuredelstein

Arthur Edelstein (Tor Browser dev) [:arthuredelstein] has approved the revision.

https://phabricator.services.mozilla.com/D1977

Comment 9

[Phabricator Automation]

Comment on attachment 8990107 [details]
Bug 1473247 - Part 2: Add a test case for making sure that IP addresses can work properly for the firstPartyDomain. r=baku, arthuredelstein

Arthur Edelstein (Tor Browser dev) [:arthuredelstein] has approved the revision.

https://phabricator.services.mozilla.com/D1978

Comment 10

[Arthur Edelstein [:arthur]]

Thanks and sorry for the delay!

Comment 11

[Tim Huang[:timhuang]]

Try looks good.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f03f95724d5315a32daa9d5b578f55b0599872e3

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03e45d7472a0
Part 1: Fixing the issue that the IP addresses won't be set for first party domains. r=arthuredelstein,baku

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01f390f36d95
Part 2: Add a test case for making sure that IP addresses can work properly for the firstPartyDomain. r=arthuredelstein,baku

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/03e45d7472a0
https://hg.mozilla.org/mozilla-central/rev/01f390f36d95