Closed
Bug 1473253
Opened 6 years ago
Closed 6 years ago
Stop setting onerror attribute on tabs
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: manishkk, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
|
1.09 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Since tabbrowser itself doesn't load icons from the network anymore, I suppose this error handling isn't needed anymore. Is there a risk that we get invalid data URIs or something?
https://searchfox.org/mozilla-central/rev/97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.xml#116
https://searchfox.org/mozilla-central/rev/97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.js#2223
Flags: needinfo?(dtownsend)
|
||
Comment 1•6 years ago
|
||
We should never get invalid data URIs to my knowledge. We do still have some cases where we pass the icon url directly through when they are chrome: for example so maybe if they are broken this still might have some effect. Probably not needed though.
Flags: needinfo?(dtownsend)
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(dao+bmo)
Priority: P5 → P3
|
|
Reporter | |
Updated•6 years ago
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
|
|
Assignee | |
Comment 2•6 years ago
|
||
Need to remove these lines only?
> https://searchfox.org/mozilla-central/rev/
> 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> xml#116
>
> https://searchfox.org/mozilla-central/rev/
> 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> js#2223
Flags: needinfo?(dao+bmo)
|
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to Manish Kumar [:manishkk] from comment #2)
> Need to remove these lines only?
>
>
> > https://searchfox.org/mozilla-central/rev/
> > 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> > xml#116
> >
> > https://searchfox.org/mozilla-central/rev/
> > 97d488a17a848ce3bebbfc83dc916cf20b88451c/browser/base/content/tabbrowser.
> > js#2223
Yep.
Flags: needinfo?(dao+bmo)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Please review.
Thanks
Attachment #8990775 -
Flags: review?(dao+bmo)
|
|
Reporter | |
Comment 5•6 years ago
|
||
Comment on attachment 8990775 [details] [diff] [review]
Patch_Bug1473253
Looks good, thanks!
Attachment #8990775 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f823c4cfd7ce
Stop setting onerror attribute on tabs. r=dao
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•