Closed Bug 1473266 Opened 2 years ago Closed 2 years ago

[BinAST] Remove in-tree newline_if_not_empty

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

binjs_meta 0.3.8 contains newline_if_not_empty
we can remove in-tree one.
Blocks: 1455547
Comment on attachment 8989921 [details] [diff] [review]
Remove in-tree newline_if_not_empty.

Bumped the depending binjs_meta version and removed NewLineIfNotEmpty trait which is moved there.
Attachment #8989921 - Flags: review?(dteller)
Attachment #8989921 - Flags: review?(dteller) → review+
I modified the file locally with the result of `./mach vendor rust` which updates in-tree binjs_meta, and got r=glandium on that part.
(also I bumped into bug 1461553, which is solved by removing ~/.cargo/registry)
I'll land this patch after extra try run.
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a8c94838695
Remove in-tree newline_if_not_empty. r=Yoric,glandium
https://hg.mozilla.org/mozilla-central/rev/4a8c94838695
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.