1473333 - Log success rates with telemetry probe in HttpChannel onstartrequest

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P1)

Description

[Daniel Stenberg [:bagder]]

With a probe there that logs the HTTP success rate at this point, we should be able to compare error rates for users using TRR with those that don't use TRR.

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: bug 1473333 - add Telemetry probe HTTP_CHANNEL_ONSTART_SUCCESS

To measure success rate in nsHttpChannel::OnStartRequest

MozReview-Commit-ID: Jb2ixouu6zU

Comment 2

[Chris H-C :chutten]

Hi!

New data collections are subject to Data Collection Review by a Data Steward: https://wiki.mozilla.org/Firefox/Data_Collection

(It's just a short "form" to fill out, then getting an r? from a Steward)

Comment 3

[Phabricator Automation]

Comment on attachment 8989918 [details]
bug 1473333 - add Telemetry probe HTTP_CHANNEL_ONSTART_SUCCESS

Patrick McManus [:mcmanus] has approved the revision.

https://phabricator.services.mozilla.com/D1963

Comment 4

[Daniel Stenberg [:bagder]]

Attachment: telemetry-http_chanel_onstart_success.txt

Data Collection Review for Telemetry::HTTP_CHANNEL_ONSTART_SUCCESS

Comment 5

[François Marier [:francois]]

Comment on attachment 8990215 [details]
telemetry-http_chanel_onstart_success.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Daniel Stenberg.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON, only in pre-release channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No)

No, permanent.

Comment 6

[Daniel Stenberg [:bagder]]

Attachment: 0001-bug-1473333-add-Telemetry-probe-HTTP_CHANNEL_ONSTART.patch

(Unable to land this in lando, bug 1473810, I'm taking this route instead)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce3885524a1e
add Telemetry probe HTTP_CHANNEL_ONSTART_SUCCESS r=mcmanus

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ce3885524a1e