Closed
Bug 14734
Opened 25 years ago
Closed 25 years ago
redundant code in modules/libimg/src/ilNetReader.cpp
Categories
(Core :: Graphics: ImageLib, defect, P3)
Core
Graphics: ImageLib
Tracking
()
VERIFIED
FIXED
M13
People
(Reporter: colin, Assigned: pnunn)
Details
modules/libimg/src/ilNetReader.cpp NS_IMETHODIMP NetReaderImpl::WriteReady(PRUint32* max_read) { if (ilContainer != NULL) { *max_read =IL_StreamWriteReady(ilContainer); if (*max_read < 0) *max_read = 0; } return NS_OK; } max_read is UNSIGNED so why bother with the "less than zero" test! Colin.
Yep. Thanks for the catch. Its an artifact from old code which had negative error return values. Ill check it in when the window opens for general checkins. -pn
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 3•25 years ago
|
||
colin@theblakes.com, would you like to verify this? (Otherwise, I'll rubber-stamp it as verified.) Thanks!
Reporter | ||
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 4•25 years ago
|
||
Yep, the redundant code is gone. This should be closed.
Comment 5•25 years ago
|
||
Thanks, Colin!
You need to log in
before you can comment on or make changes to this bug.
Description
•