redundant code in modules/libimg/src/ilNetReader.cpp

VERIFIED FIXED in M13

Status

()

defect
P3
minor
VERIFIED FIXED
20 years ago
20 years ago

People

(Reporter: colin, Assigned: pnunn)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

modules/libimg/src/ilNetReader.cpp

NS_IMETHODIMP
NetReaderImpl::WriteReady(PRUint32* max_read)
{
    if (ilContainer != NULL) {
        *max_read =IL_StreamWriteReady(ilContainer);
        if (*max_read < 0)
            *max_read = 0;
    }
    return NS_OK;
}

max_read is UNSIGNED so why bother with the "less than zero" test!

Colin.
Status: NEW → ASSIGNED
Target Milestone: M13
Yep. Thanks for the catch.
Its an artifact from old code which had
negative error return values.

Ill check it in when the window opens for
general checkins.
-pn
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
checked in.
closed as fixed.
colin@theblakes.com, would you like to verify this? (Otherwise, I'll rubber-stamp
it as verified.)

Thanks!
Status: RESOLVED → VERIFIED
Yep, the redundant code is gone. This should be closed.
Thanks, Colin!
You need to log in before you can comment on or make changes to this bug.