Closed
Bug 1473426
Opened 6 years ago
Closed 6 years ago
Port Bug 1353844 "Send permissions to the content process before restoring sessionStorage" to SeaMonkey
Categories
(SeaMonkey :: Session Restore, enhancement)
Tracking
(seamonkey2.49esr unaffected, seamonkey2.60 fixed, seamonkey2.53 affected, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.60
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.60 | --- | fixed |
| seamonkey2.53 | --- | affected |
| seamonkey2.57esr | --- | fixed |
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(2 files)
|
2.29 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
3.08 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
From bug 1353844: Currently we don't send permissions to the content process before restoring sessionstorage. I will attach a patch to support sending that data down.
|
Assignee | |
Comment 1•6 years ago
|
||
Our sessionrestore code is somewhat ancient but the patches bring them up a little closer to Fx and checking the sessionstore.json files and the restore do not cause additional problems.
Attachment #8989882 -
Flags: review?(iann_bugzilla)
Attachment #8989882 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8989883 -
Flags: review?(iann_bugzilla)
Attachment #8989883 -
Flags: approval-comm-esr60?
Comment on attachment 8989882 [details] [diff] [review] 1473426-part1-origin.patch LGTM r/a=me
Attachment #8989882 -
Flags: review?(iann_bugzilla)
Attachment #8989882 -
Flags: review+
Attachment #8989882 -
Flags: approval-comm-esr60?
Attachment #8989882 -
Flags: approval-comm-esr60+
Comment on attachment 8989883 [details] [diff] [review] 1473426-part2-origin.patch LGTM r/a=me
Attachment #8989883 -
Flags: review?(iann_bugzilla)
Attachment #8989883 -
Flags: review+
Attachment #8989883 -
Flags: approval-comm-esr60?
Attachment #8989883 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/6eef2fc30a34 Port Bug 1353844 [Part 1: Parse origin strings correctly in SessionStorage::restore] to SeaMonkey. r=IanN https://hg.mozilla.org/comm-central/rev/343708353438 Port Bug 1353844 [Part 2: Send permissions to the content process before restoring SessionStorage] to SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•6 years ago
|
||
Patches for both trees rebased for new file location in components/sessionstore. The orginal one was for 2.53. When doing the pushed I noticed that part 2 used console.error(e). Same as Fx but I found it inconsistent with the other occurences in the file and changed it to Cu.reportError(e); https://hg.mozilla.org/releases/comm-esr60/rev/f39338e91f78e959ec727f957f5a06ba26c9b7da https://hg.mozilla.org/releases/comm-esr60/rev/dae86f055ffab43082e353d25172b7f788c65046
status-seamonkey2.57esr:
--- → fixed
status-seamonkey2.60:
--- → fixed
Target Milestone: --- → seamonkey2.60
You need to log in
before you can comment on or make changes to this bug.
Description
•