Closed Bug 1473441 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11792 - [css-properties-values-api] Require PropertyDescriptor.inherits.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11792 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11792
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Require PropertyDescriptor.inherits.
>  
>  As of a recent spec change, the 'inherits' field must now be set.
>  
>  This patch changes all calls to CSS.registerProperty (that are missing
>  'inherits') such that 'inherits' is explicitly set to 'false', which was
>  the old default.
>  
>  In wpt/css/css-properties-values-api/register-property.html, I have added
>  a new test to very that we throw an exception if it's omitted.
>  
>  Note that CSS.registerProperty API is an unshipped feature behind the
>  CSSVariables2 flag.
>  
>  R=mstensho@chromium.org
>  
>  Bug: 860289
>  Change-Id: I14aa02d40c69e0ff6d1160160a8f772cb5159092
>  Reviewed-on: https://chromium-review.googlesource.com/1126303
>  WPT-Export-Revision: 7123a2226f233de82d3fb2aafb6a293f6fa8dc73
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 9 tests and 150 subtests
OK     : 8
PASS   : 2
FAIL   : 149

New tests that have failures or other problems:
/css/css-properties-values-api/register-property.html
    registerProperty only allows omitting initialValue if syntax is '*': FAIL
    registerProperty requires inherits: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77deadcbf7c1
[wpt PR 11792] - [css-properties-values-api] Require PropertyDescriptor.inherits., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfcf0e22481d
[wpt PR 11792] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/77deadcbf7c1
https://hg.mozilla.org/mozilla-central/rev/bfcf0e22481d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.