1473441 - [wpt-sync] Sync PR 11792 - [css-properties-values-api] Require PropertyDescriptor.inherits.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11792 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11792
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:
>  [css-properties-values-api] Require PropertyDescriptor.inherits.
>  
>  As of a recent spec change, the 'inherits' field must now be set.
>  
>  This patch changes all calls to CSS.registerProperty (that are missing
>  'inherits') such that 'inherits' is explicitly set to 'false', which was
>  the old default.
>  
>  In wpt/css/css-properties-values-api/register-property.html, I have added
>  a new test to very that we throw an exception if it's omitted.
>  
>  Note that CSS.registerProperty API is an unshipped feature behind the
>  CSSVariables2 flag.
>  
>  R=[e-mail]
>  
>  Bug: 860289
>  Change-Id: I14aa02d40c69e0ff6d1160160a8f772cb5159092
>  Reviewed-on: https://chromium-review.googlesource.com/1126303
>  WPT-Export-Revision: 7123a2226f233de82d3fb2aafb6a293f6fa8dc73

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a260a109b2c30ef3750d0bdc3add27027619da09

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=92e949662d1fa053f2486b24691f02d22413e204

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 9 tests and 150 subtests
OK     : 8
PASS   : 2
FAIL   : 149

New tests that have failures or other problems:
/css/css-properties-values-api/register-property.html
    registerProperty only allows omitting initialValue if syntax is '*': FAIL
    registerProperty requires inherits: FAIL

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77deadcbf7c1
[wpt PR 11792] - [css-properties-values-api] Require PropertyDescriptor.inherits., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfcf0e22481d
[wpt PR 11792] - Update wpt metadata, a=testonly

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/77deadcbf7c1
https://hg.mozilla.org/mozilla-central/rev/bfcf0e22481d