1473515 - AutoDisableUndo always re-enables undo with unlimited

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/html/nsTextEditorState.cpp#184
The destructor of AutoDisableUndo always calls EditorBase::EnableUndoRedo() without argument. Then, -1 is used for unlimited undo/redo stack:
https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/editor/libeditor/EditorBase.h#415
However, typically, <input> and <textarea> is limited to 1000.
https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/html/nsTextEditorState.cpp#1517
https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/html/nsITextControlElement.h#190
So, AutoDisableUndo should store the limitation of undo/redo stack before disabling it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e8ac2ccf636fe4e189437e7129d892c7ce5adc2

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1473515 - Make AutoDisableUndo restores enabled state of undo/redo with previous number of maximum transactions

Calling EditorBase::EnableUndoRedo() without argument means that editor supports
unlimited undo/redo stack.  AutoDisableUndo class calls it without argument
when it needs to restore undo/redo feature.

However, <input type="text"> and <textarea> limits number of maximum
transactions up to 1,000, perhaps for footprint.  So, AutoDisableUndo should
store the last number of maximum transactions before disabling undo/redo from
the constructor.

Review commit: https://reviewboard.mozilla.org/r/255030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255030/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8990008 [details]
Bug 1473515 - Make AutoDisableUndo restores enabled state of undo/redo with previous number of maximum transactions

https://reviewboard.mozilla.org/r/255030/#review262094

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1814ad4986ce
Make AutoDisableUndo restores enabled state of undo/redo with previous number of maximum transactions r=m_kato

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1814ad4986ce