1473628 - Remove unused support of actors as function in ActorPool

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The following code should no longer be used:
https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/devtools/server/actors/common.js#220-222
We used to support registering function in pools that had to be called the first time the actor was used. I think it was dropped the day we introduced ObservedActorFactory.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1473628 - Stop supporting actors as functions.

Review commit: https://reviewboard.mozilla.org/r/255070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255070/

Comment 2

[Alexandre Poirot [:ochameau]]

try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c703db35c66db773744583d07433e3cb6eb0bfce

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8990041 [details]
Bug 1473628 - Stop supporting actors as functions.

https://reviewboard.mozilla.org/r/255070/#review262310

Well, it seems reasonable, but it's also hard for me to be sure this is correct without combing each call site...

Could we use this opportunity to throw an error if `prefix` ends up `null` (after checking both `actorPrefix` and `typeName`)?  This way it would be easier to verify that it's correct.

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 8990041 [details]
Bug 1473628 - Stop supporting actors as functions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255070/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7bd2557255a
Stop supporting actors as functions. r=jryans

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c7bd2557255a