1473685 - When a user "disables protection" on a site, and no trackers are detected, indicate that TP is turned off instead of on

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Tanvi Vyas[:tanvi]]

In Firefox62+, assume a user "disables protection" on a site. Then they visit a page on that site with no trackers detected at the moment.  Even though there are no trackers yet, any trackers that load in the future will be allowed, since protection is disabled on the site.

In 62+, the Control Center UI shows a shield and "Tracking Protection: ON" in this case.  Instead, it should show a shield with a cross out and "Tracking Protection: OFF".

If we could fix this and uplift it to 62, that would be great.  But since it is an edge case, it would be okay if this inconsistency existed for one release cycle.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1473685 - When a user "disables protection" on a site, and no trackers are detected, indicate that TP is turned off instead of on.

Review commit: https://reviewboard.mozilla.org/r/255760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255760/

Comment 2

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5491d25ebb25308eddde9ebbccd4d3d7004df264

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8990679 [details]
Bug 1473685 - When a user "disables protection" on a site, and no trackers are detected, indicate that TP is turned off instead of on.

https://reviewboard.mozilla.org/r/255760/#review262512

LGTM. While I'm here, a reminder: please consider sharing a link to a testcase when filing bugs like this one. :)

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8990679 [details]
Bug 1473685 - When a user "disables protection" on a site, and no trackers are detected, indicate that TP is turned off instead of on.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255760/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

Updated tests to cover this.

> LGTM. While I'm here, a reminder: please consider sharing a link to a testcase when filing bugs like this one. :)

In this case, you need to find a site that triggers tracking protection and add an exception, then visit a page on the site without trackers (I use the favicon), so for example: https://www.zeit.de/index and https://www.zeit.de/favicon.ico

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f21f24461733
When a user "disables protection" on a site, and no trackers are detected, indicate that TP is turned off instead of on. r=nhnt11

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f21f24461733

Comment 8

[Tanvi Vyas[:tanvi]]

Please request uplift once this has baked for a couple days.

Comment 9

[Johann Hofmann [:johannh]]

Comment on attachment 8990679 [details]
Bug 1473685 - When a user "disables protection" on a site, and no trackers are detected, indicate that TP is turned off instead of on.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1470020
[User impact if declined]: Small edge case where we go against UX spec for the TP UI by saying TP is on when the user has actually added an exception
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Works for me in Nightly
[Needs manual test from QE? If yes, steps to reproduce]: Not really
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Adds three simple lines of CSS, has extensive test coverage
[String changes made/needed]: None

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8990679 [details]
Bug 1473685 - When a user "disables protection" on a site, and no trackers are detected, indicate that TP is turned off instead of on.

Minor fix in UI for edge case, let's uplift for beta 9.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9069ef47ae90

Comment 12

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this issue is fixed, I verified using Fx 63.0a1, build ID: 20180722220044 and Fx 62.0b10, on Windows 10 x64, Ubuntu 14.04 LTS and mac OS 10.13.5 beta.