1473779 - Make writing-mode and direction non-animatable.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

Per https://github.com/w3c/csswg-drafts/issues/2751

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1473779: Reformat most of inherited_box.mako.rs.

image-orientation is being changed as we speak, so I left it there to avoid
bitrot.

Review commit: https://reviewboard.mozilla.org/r/255192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255192/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1473779: Make writing-mode and direction non-animatable.

Per https://github.com/w3c/csswg-drafts/issues/2751

Review commit: https://reviewboard.mozilla.org/r/255194/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255194/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8990169 [details]
Bug 1473779: Reformat most of inherited_box.mako.rs.

image-orientation is being changed as we speak, so I left it there to avoid
bitrot.

Review commit: https://reviewboard.mozilla.org/r/255192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255192/

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8990170 [details]
Bug 1473779: Make writing-mode and direction non-animatable.

Per https://github.com/w3c/csswg-drafts/issues/2751

Review commit: https://reviewboard.mozilla.org/r/255194/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255194/

Comment 5

[Hiroyuki Ikezoe (:hiro)]

We have test cases in testing/web-platform/tests/web-animations/animation-model/animation-types/property-list.js, those tests should be dropped too.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8990169 [details]
Bug 1473779: Reformat most of inherited_box.mako.rs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255192/diff/1-2/

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8990170 [details]
Bug 1473779: Make writing-mode and direction non-animatable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255194/diff/1-2/

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8990169 [details]
Bug 1473779: Reformat most of inherited_box.mako.rs.

https://reviewboard.mozilla.org/r/255192/#review262104

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 8990170 [details]
Bug 1473779: Make writing-mode and direction non-animatable.

https://reviewboard.mozilla.org/r/255194/#review262106

Can you please add a WPT that checks that they are non-animatable?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a280d0239d
Reformat most of inherited_box.mako.rs. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e815e6e442b
Make writing-mode and direction non-animatable. r=heycam

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Added it to web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11829 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d8a280d0239d
https://hg.mozilla.org/mozilla-central/rev/8e815e6e442b

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged