1473793 - Minor cleanups.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1473793: Remove dead code.

Review commit: https://reviewboard.mozilla.org/r/255202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255202/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1473793: Add a clone helper that works regardless of whether the property is logical.

Review commit: https://reviewboard.mozilla.org/r/255204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255204/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1473793: Other minor properties.mako.rs cleanups and improvements.

Also, add an is_logical method, which we'll use in a bit.

Review commit: https://reviewboard.mozilla.org/r/255206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255206/

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8990179 [details]
Bug 1473793: Remove dead code.

https://reviewboard.mozilla.org/r/255202/#review262112

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8990180 [details]
Bug 1473793: Add a clone helper that works regardless of whether the property is logical.

https://reviewboard.mozilla.org/r/255204/#review262114

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8990181 [details]
Bug 1473793: Other minor properties.mako.rs cleanups and improvements.

https://reviewboard.mozilla.org/r/255206/#review262116

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5834f9aff57
Remove dead code. r=heycam
https://hg.mozilla.org/integration/autoland/rev/a9501d2a9632
Add a clone helper that works regardless of whether the property is logical. r=heycam
https://hg.mozilla.org/integration/autoland/rev/c18adbadea5a
Other minor properties.mako.rs cleanups and improvements. r=heycam

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out 3 changesets (bug 1473793) for build bustages

Backout: https://hg.mozilla.org/integration/autoland/rev/443e0ae6ce0eec7ee85529139f13fcb5077d47f3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c18adbadea5ad6cb176a3b4c2d2d113e56e6c796&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&selectedJob=186776081 

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=186776081&repo=autoland&lineNumber=1040

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf8f2d1fa6cf
Remove dead code. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e7f427c1954
Add a clone helper that works regardless of whether the property is logical. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f3c4484202b
Other minor properties.mako.rs cleanups and improvements. r=heycam

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/cf8f2d1fa6cf
https://hg.mozilla.org/mozilla-central/rev/7e7f427c1954
https://hg.mozilla.org/mozilla-central/rev/5f3c4484202b