1473881 - gfx/vr/VRManager.cpp: error: undefined symbol: mozilla::gfx::VRService::Create()

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Jan Beich]

On Tier3 platforms VR support is disabled at built but referenced.

$ ./mach bootstrap
$ ./mach build
[...]
17:42.34 libxul.so
17:42.77 /usr/bin/ld.lld: error: undefined symbol: mozilla::gfx::VRService::Create()
17:42.77 >>> referenced by Unified_cpp_gfx_vr0.cpp
17:42.77 >>>               ../../gfx/vr/Unified_cpp_gfx_vr0.o:(mozilla::gfx::VRManager::VRManager())
17:42.77 /usr/bin/ld.lld: error: undefined symbol: mozilla::gfx::VRService::~VRService()
17:42.77 >>> referenced by Unified_cpp_gfx_vr0.cpp
17:42.77 >>>               ../../gfx/vr/Unified_cpp_gfx_vr0.o:(mozilla::gfx::VRManager::VRManager())
17:42.77 /usr/bin/ld.lld: error: undefined symbol: mozilla::gfx::VRService::GetAPIShmem()
17:42.77 >>> referenced by Unified_cpp_gfx_vr0.cpp
17:42.77 >>>               ../../gfx/vr/Unified_cpp_gfx_vr0.o:(mozilla::gfx::VRManager::VRManager())
17:42.77 /usr/bin/ld.lld: error: undefined symbol: mozilla::gfx::VRService::~VRService()
17:42.77 >>> referenced by Unified_cpp_gfx_vr0.cpp
17:42.77 >>>               ../../gfx/vr/Unified_cpp_gfx_vr0.o:(mozilla::gfx::VRManager::~VRManager())
17:42.77 /usr/bin/ld.lld: error: undefined symbol: mozilla::gfx::VRService::Start()
17:42.77 >>> referenced by Unified_cpp_gfx_vr0.cpp
17:42.77 >>>               ../../gfx/vr/Unified_cpp_gfx_vr0.o:(mozilla::gfx::VRManager::RefreshVRDisplays(bool))
17:42.77 /usr/bin/ld.lld: error: undefined symbol: mozilla::gfx::VRService::Stop()
17:42.77 >>> referenced by Unified_cpp_gfx_vr0.cpp
17:42.77 >>>               ../../gfx/vr/Unified_cpp_gfx_vr0.o:(mozilla::gfx::VRManager::CheckForInactiveTimeout())
17:42.77 /usr/bin/ld.lld: error: undefined symbol: mozilla::gfx::VRService::Stop()
17:42.77 >>> referenced by Unified_cpp_gfx_vr0.cpp
17:42.78 >>>               ../../gfx/vr/Unified_cpp_gfx_vr0.o:(mozilla::gfx::VRManager::CheckForInactiveTimeout())
17:42.84 clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Comment 1

[Jan Beich]

Attachment: Bug 1473881 - Unbreak build on Tier3 after bug 1466699.

Review commit: https://reviewboard.mozilla.org/r/255336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255336/

Comment 2

[Jan Beich]

On r+, please, mark checkin-needed. Ignore for r-.

Comment 3

[:kip (Kearwood Gilbert)]

Comment on attachment 8990302 [details]
Bug 1473881 - Unbreak build on Tier3 after bug 1466699.

https://reviewboard.mozilla.org/r/255336/#review262264

LGTM, thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13fe520dd190
Unbreak build on Tier3 after bug 1466699. r=kip

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/13fe520dd190