Closed Bug 1473967 Opened Last year Closed Last year

Add C++/Rust glue code for the SDP attribute maxptime

Categories

(Core :: WebRTC: Signaling, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: johannes.willbold, Assigned: johannes.willbold)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The rsdparsa is missing the C++ interface code for the maxptime attribute.
Assignee: nobody → johannes.willbold
Status: UNCONFIRMED → NEW
Rank: 15
Ever confirmed: true
Priority: -- → P2
Comment on attachment 8990421 [details]
Bug 1473967: Added C++/Rust glue code for maxptime,

https://reviewboard.mozilla.org/r/255500/#review262528

::: commit-message-e8b73:3
(Diff revision 1)
> +Bug 1473967: Added C++/Rust glue code for maxptime, r=dminor
> +
> +Added the C++/Rust gleu code for maxptime.

typo: s/gleu/glue

::: media/webrtc/signaling/src/sdp/rsdparsa_capi/src/attribute.rs:194
(Diff revision 1)
> +        *ret = *max_ptime;
> +        return NS_OK;
> +    }
> +    NS_ERROR_INVALID_ARG
> +}
> +

nit: please remove extra newline
Attachment #8990421 - Flags: review?(dminor) → review+
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/ec17ed2e91b9
Added C++/Rust glue code for maxptime, r=dminor
https://hg.mozilla.org/mozilla-central/rev/ec17ed2e91b9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.