1473967 - Add C++/Rust glue code for the SDP attribute maxptime

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Johannes Willbold]

The rsdparsa is missing the C++ interface code for the maxptime attribute.

Comment 1

[Johannes Willbold]

Attachment: Bug 1473967: Added C++/Rust glue code for maxptime,

Added the C++/Rust gleu code for maxptime.
Added the C++ unit test CheckMaxPtime.

Review commit: https://reviewboard.mozilla.org/r/255500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255500/

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8990421 [details]
Bug 1473967: Added C++/Rust glue code for maxptime,

https://reviewboard.mozilla.org/r/255500/#review262528

::: commit-message-e8b73:3
(Diff revision 1)
> +Bug 1473967: Added C++/Rust glue code for maxptime, r=dminor
> +
> +Added the C++/Rust gleu code for maxptime.

typo: s/gleu/glue

::: media/webrtc/signaling/src/sdp/rsdparsa_capi/src/attribute.rs:194
(Diff revision 1)
> +        *ret = *max_ptime;
> +        return NS_OK;
> +    }
> +    NS_ERROR_INVALID_ARG
> +}
> +

nit: please remove extra newline

Comment 3

[Johannes Willbold]

Comment on attachment 8990421 [details]
Bug 1473967: Added C++/Rust glue code for maxptime,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255500/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec17ed2e91b9
Added C++/Rust glue code for maxptime, r=dminor

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ec17ed2e91b9