1474095 - Addon-tip-icon for web-ext in about:debugging cut (at low window width)

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[rugk]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180625102006

Steps to reproduce:

1. Set the language of your Firefox to German.
2. Go to about:debugging.


Actual results:

The "? icon" there is cut. 

See https://hostux.pics/images/2018/07/07/d75022fbef53e82932e1643a1dc8dee3.png


Expected results:

It should keep it's size.

**I would like to work on this bug and actually I've already found a solution.**

Comment 1

[rugk]

(Also reproducible in English if you make the window width quite low…)

Comment 2

[David Olah]

I managed to reproduce this issue on Firefox 61.0.1, 62.0b7 and Nightly 63.0a1 (2018-07-11), Ubuntu 16.04.

Comment 3

[rugk]

Great, so I'd like to take this, as mentioned before.

I'd just get my invitation for https://janitor.technology/, so I can start with it.

Comment 4

[rugk]

Attachment: Prevent shrinking of the add-on tip icon in about:debugging

Thanks to Janitor.technology, so I could made this. Works really great!

Comment 5

[rugk]

Anyone here? I just clicked some review buttons… don't know how to actually get one to review this? Is there anything I can do?

Comment 6

[Trevor Rowbotham [:rowbot]]

rguk, based on the file that you have modified, this bug is in the wrong component. I'm going to move it to the DevTools component so that the Dev Tools developers can find this. You will likely have better luck finding an appropriate reviewer there.

:Harald Kirschner, are you able to review this patch or redirect to someone more appropriate?

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 8991463 [details] [diff] [review]
Prevent shrinking of the add-on tip icon in about:debugging

Jan, can you have a look? Thanks.

Comment 8

[Jan Keromnes [:janx]]

Comment on attachment 8991463 [details] [diff] [review]
Prevent shrinking of the add-on tip icon in about:debugging

Hi rugk, I was able to confirm that your patch indeed fixes the bug. Thank you for working on this! (Also, I'm glad that janitor.technology was useful to you!)

As a previous owner of about:debugging, I approve this fix. Please just update the patch description to our usual format, like so:

> Bug 1474095 - Prevent shrinking of the add-on tip icon in about:debugging. r=janx

Then, please feel free to set the "checkin-needed" keyword on this bug (if you can't or don't know how, please feel free to "needinfo?" me).

Comment 9

[:Harald Kirschner :digitarald]

Thanks Jan for jumping in!

Comment 10

[rugk]

Attachment: Bug 1474095 - Prevent shrinking of the add-on tip icon in about:debugging. r=janx

changed description as per request of @janx

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a6fd029201
"Addon-tip-icon for web-ext in about:debugging cut (at low window width)" [c=c4609174]. r=janx

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e6a6fd029201

Comment 13

[Jan Keromnes [:janx]]

rugk, congratulations on your first patch to Firefox! (Belatedly, and if I'm not mistaken.)

As you've probably seen in the tracking flags, your improvement to about:debugging will be live in Firefox 63. :)

Comment 14

[rugk]

Ah, yeah, thanks. (And thanks for making Janitor.technology, yet again. :) )


Unless I forget it, I'll certainly celebrate it when FF 63 get's stable. ;)

Comment 15

[rugk]

BTW if anyone could vouch for me on Mozillians, I am https://mozillians.org/rugk there.